Make queriesDir optional via withQueriesDir builder#46
Merged
Conversation
Consumers that feed all their operations through GeneratedGraphQLClient (inline or Twig sources) have no .graphql files on disk, so requiring a queriesDir forced them to invent a dummy path. Drop queriesDir from Config::create() and add a withQueriesDir() builder so it's opt-in like the other dir-scoped settings (inlineProcessing, twigProcessing). Planner and PlanExecutor skip their .graphql finders when queriesDir is null. Breaking change: positional create() callers shift by one, and any caller that needs a queries directory now has to chain withQueriesDir() -- everything in-tree (tests, examples, README) is updated accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers that feed all their operations through GeneratedGraphQLClient (inline or Twig sources) have no .graphql files on disk, so requiring a queriesDir forced them to invent a dummy path.
Drop queriesDir from Config::create() and add a withQueriesDir() builder so it's opt-in like the other dir-scoped settings (inlineProcessing, twigProcessing). Planner and PlanExecutor skip their .graphql finders when queriesDir is null. Breaking change: positional create() callers shift by one, and any caller that needs a queries directory now has to chain withQueriesDir() -- everything in-tree (tests, examples, README) is updated accordingly.