Conversation
PR #43 taught data classes to accept and store $hooks, and the planner marks every transitive parent as hook-using -- but the fragment-spread getter templates in DataClassGenerator kept hard-coding `new Child($this->data)`, so the stored hooks never reached the child. PHPStan flagged each intermediate class with arguments.count on the child constructor and property.onlyWritten on its own $hooks property. Delegate the constructor expression to $typeInitializer, which already consults ClassHookUsageRegistry via ObjectTypeInitializer, instead of rebuilding `new X(...)` by hand in four places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #43 taught data classes to accept and store $hooks, and the planner marks every transitive parent as hook-using -- but the fragment-spread getter templates in DataClassGenerator kept hard-coding
new Child($this->data), so the stored hooks never reached the child. PHPStan flagged each intermediate class with arguments.count on the child constructor and property.onlyWritten on its own $hooks property.Delegate the constructor expression to $typeInitializer, which already consults ClassHookUsageRegistry via ObjectTypeInitializer, instead of rebuilding
new X(...)by hand in four places.