Conversation
The `@hook` directive added in #43 forwards `$this->hooks` into child constructors via `ObjectTypeInitializer`, which consults a `ClassHookUsageRegistry` owned by `PlanExecutor`. Projects that registered their own `ObjectTypeInitializer` via `Config::withTypeInitializer()` to customize a specific value object (Money, Url, …) broke the hook forwarding: the dedup-by-class-name in `DelegatingTypeInitializer` let the user instance — constructed without the registry — overwrite the built-in one, so every `new Child($data)` was emitted without hooks. Splitting the two roles removes the footgun. `ObjectTypeInitializer` is now strictly the internal catch-all (registry injected via constructor, no extension surface). Userland registers plain `TypeInitializer` instances that match only their specific class; the delegation chain runs them ahead of the catch-all, so type-specific handlers win for their own types and everything else falls through to the built-in one with hooks intact. Breaking change for any config that wrapped a handler in `ObjectTypeInitializer` — unwrap it and pass the inner `TypeInitializer` directly to `withTypeInitializer()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@hookdirective added in #43 forwards$this->hooksinto child constructors viaObjectTypeInitializer, which consults aClassHookUsageRegistryowned byPlanExecutor. Projects that registered their ownObjectTypeInitializerviaConfig::withTypeInitializer()to customize a specific value object (Money, Url, …) broke the hook forwarding: the dedup-by-class-name inDelegatingTypeInitializerlet the user instance — constructed without the registry — overwrite the built-in one, so everynew Child($data)was emitted without hooks.Splitting the two roles removes the footgun.
ObjectTypeInitializeris now strictly the internal catch-all (registry injected via constructor, no extension surface). Userland registers plainTypeInitializerinstances that match only their specific class; the delegation chain runs them ahead of the catch-all, so type-specific handlers win for their own types and everything else falls through to the built-in one with hooks intact.Breaking change for any config that wrapped a handler in
ObjectTypeInitializer— unwrap it and pass the innerTypeInitializerdirectly towithTypeInitializer().