Add trailing comma via suffixLast when addCommaAfterEachArgument is false#11
Merged
Add trailing comma via suffixLast when addCommaAfterEachArgument is false#11
Conversation
…alse When addCommaAfterEachArgument is false, dumpCall previously added no commas at all. PHP CS Fixer expects a trailing comma on the last argument in multiline function calls. Use suffixLast to add a comma only to the last argument line instead of every line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
addCommaAfterEachArgumentisfalseindumpCall, no commas were added at all. PHP CS Fixer expects a trailing comma on the last argument in multiline function calls.This changes the
falsebehavior to usesuffixLast(',', $args)instead of just$args, adding a comma only to the last argument line. This is useful for multi-line constructs likematchexpressions used as function arguments:Both the static call path and object call path are updated.
Test plan