fix: remove lifetime from RuntimeCache - #129
Merged
Merged
Conversation
theHamsta
force-pushed
the
fix-runtime-cache
branch
from
July 21, 2026 15:55
82bc499 to
f4659f1
Compare
RuntimeCache can outlive an engine and be shared between engines.
theHamsta
force-pushed
the
fix-runtime-cache
branch
from
July 30, 2026 11:26
f4659f1 to
2fa7f74
Compare
RuntimeCache is internally synchronized with a shared mutex. So all methods can be used safely with a shared reference.
theHamsta
commented
Jul 30, 2026
| "void log(Severity severity, AsciiChar const* msg)", | ||
| "void log(int32_t severity, char const* msg)", | ||
| ) | ||
| // RuntimeCache is internally synchronized via shared_mutex |
Contributor
Author
There was a problem hiding this comment.
a bit risky, but currently this just affects RuntimeCache. It avoids use transmuting in Rust code.
The semantics of the const would actually be given for the C++ object. RuntimeCache can be used safely with a shared reference.
mtavenrath
approved these changes
Jul 30, 2026
mtavenrath
left a comment
mtavenrath
left a comment
Contributor
There was a problem hiding this comment.
remove the branch in cargo.toml in case this change for development purposes only. besides that approved.
|
|
||
| [dependencies] | ||
| rustnn = { git = "https://github.com/rustnn/rustnn/", features = [ | ||
| rustnn = { git = "https://github.com/rustnn/rustnn/", branch = "update-trtx-1.6", features = [ |
Contributor
There was a problem hiding this comment.
is this intended or just required during development?
Contributor
Author
There was a problem hiding this comment.
no, it needs to be done because of API break and also when we bump a release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuntimeCache can outlive an engine and be shared between engines.