Skip to content

fix aws verify 3rd party feature #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GlenDC wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix aws verify 3rd party feature #401

GlenDC wants to merge 2 commits into from

Conversation

@GlenDC
Copy link

@GlenDC GlenDC commented Dec 14, 2025

Goal is for this PR to fix #400

@GlenDC
Copy link
Author

GlenDC commented Dec 14, 2025

Hmmm seems you cannot just combine all features of rcgen by design, so I guess cargo-hack won't work for you... that's annoying...

I do wonder why cargo clippy --no-default-features --features aws_lc_rs,pem,x509-parser --all-targets did not catch it as that is pretty much what I have in my own project for my rcgen def...

@GlenDC
remove cargo-hack again, won't work for rcgen
4d35dc7 
not all feature combos are compatible it seems,
which in a way should not ever be true, but I do
understand why it is done, so it is like it is...
@GlenDC GlenDC changed the title fix aws verify 3rd party feature + add cargo-hack to CI fix aws verify 3rd party feature Dec 15, 2025
@GlenDC
Copy link
Author

GlenDC commented Dec 15, 2025

Removed cargo-hack again as doesn't seem to work out for rcgen...

That said, still confused why it does work for you, your CI. As in I honestly, considering your current setup already, would have expected it to fail, but apparently not...

@cpu
Copy link
Member

cpu commented Dec 15, 2025

Removed cargo-hack again as doesn't seem to work out for rcgen...

It looked like the failure was from using crypto in isolation without a provider feature. I suspect grouping the crypto feature with a provider would solve that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

latest release (0.14.6) broke aws-lc-rs users due to misuse of verify propagation

2 participants

@GlenDC @cpu