fix: fail reads clearly when the peer sends a TLS 1.3 KeyUpdate - #75
Open
ArniDagur wants to merge 1 commit into
Open
fix: fail reads clearly when the peer sends a TLS 1.3 KeyUpdate#75ArniDagur wants to merge 1 commit into
ArniDagur wants to merge 1 commit into
Conversation
The kernel cannot switch traffic keys, so after a peer rekeys every read fails to decrypt with an opaque `EBADMSG`. Detect the KeyUpdate handshake message and fail the read with an explicit error instead. NewSessionTicket is still ignored. This matches Facebook's kTLS implementation: https://github.com/facebookincubator/fizz/blob/7fb7075a65ec9e669a6851669502d549e12f9e0f/fizz/experimental/ktls/AsyncKTLSSocket.cpp#L257-L280 We should implement `KeyUpdate` in the `ktls` crate at some point. There is already ongoing work (rustls#62). Until that is complete, it's best to return an explicit error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't support switching traffic keys, so after a peer rekeys every read fails to decrypt with an opaque
EBADMSG. Detect the KeyUpdate handshake message and fail the read with an explicit error instead. NewSessionTicket is still ignored.This matches Facebook's kTLS implementation's handling of both
KeyUpdateandNewSessionTicket: https://github.com/facebookincubator/fizz/blob/7fb7075a65ec9e669a6851669502d549e12f9e0f/fizz/experimental/ktls/AsyncKTLSSocket.cpp#L257-L280We should implement
KeyUpdatein thektlscrate at some point. There is already ongoing work (#62). Until that is complete, it's best to return an explicit error.