fix: report EOF without close_notify as UnexpectedEof - #74
Merged
Conversation
A transport EOF before the peer's close_notify means the TLS stream was truncated, and a TCP FIN is not authenticated, so an attacker who can inject one could silently cut a stream short. The `ktls` crate's current behaviour returns a clean `Ok(0)`, silently accepting truncation. Rustls however returns `UnexpectedEof`: https://github.com/rustls/rustls/blob/72d0dd69c08700816a3a4f45a2c24fab630c1e07/rustls/src/conn/mod.rs#L506-L510 I chose the error message of `ktls` to match `rustls`. See rustls/rustls#790
Contributor
Author
|
Could you perform the merge if you think the PR looks good? |
Member
I prefer to wait for another maintainer to do an additional round of review. |
ctz
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transport EOF before the peer's close_notify means the TLS stream was truncated. A TCP FIN is not authenticated, so an attacker who can inject one could silently cut a stream short. The
ktlscrate's current behaviour returns a cleanOk(0), silently accepting truncation.Rustls however returns
UnexpectedEof: https://github.com/rustls/rustls/blob/72d0dd69c08700816a3a4f45a2c24fab630c1e07/rustls/src/conn/mod.rs#L506-L510I chose the error message of
ktlsto matchrustls. See rustls/rustls#790