Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #286
Type of Change
Related Issues
Closes #286
Server side: rustfs/rustfs#8741
Summary of Changes
RustfsAdminClient::create_bucketnow sends HeadBucket first. A successful HeadBucket returnsCreateBucketResult::AlreadyOwnedByYouwithout sending CreateBucket. Any other answer goes on to CreateBucket, so the existing 409/503/4xx handling is unchanged. The COSI driver uses the same client method and gets the same behaviour.Pendinguntilthe writes stop.existing_bucket_skips_create_bucket(HEAD 200, PUT 503 → Ready, "already exists") andmissing_bucket_is_created(HEAD 404 → PUT).explicit_private_removes_operator_managed_anonymous_policygets an explicit HEAD route, because axum'sgetroute also answers HEAD and its handler asserts the?policyquery.Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
Verification
Additional Notes
Rust gates ran locally: fmt, clippy,
cargo nextest run --all(770 passed), doc tests,release-metadata-check,e2e-check. Console checks were not run because no console code changed.Seen on a production Tenant (RustFS 1.0.2, steady
mc mirrorwrites into the bucket):PUT /mainreturned 503 after 5 s on every retry for over 30 minutes, whileHEAD /mainanswered at once.Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.