Skip to content

Fix stale tenant progressing status in console topology#154

Merged
GatewayJ merged 1 commit into
rustfs:mainfrom
GatewayJ:fix/topology-progressing-health
Jun 28, 2026
Merged

Fix stale tenant progressing status in console topology#154
GatewayJ merged 1 commit into
rustfs:mainfrom
GatewayJ:fix/topology-progressing-health

Conversation

@GatewayJ

Copy link
Copy Markdown
Member

Type of Change

  • New Feature
  • Bug Fix
  • Documentation
  • Performance Improvement
  • Test/CI
  • Refactor
  • Other:

Related Issues

N/A

Summary of Changes

  • Ignore stale legacy Progressing=True tenant conditions when the tenant is already Ready=True in the Console topology summary.
  • Preserve legacy compatibility for tenants that only expose Progressing=True and are not ready yet, including primary reason and next action mapping.
  • Prune legacy Progressing conditions from future operator status writes so refreshed statuses converge to Ready/Reconciling/Degraded only.
  • Add regression coverage for ready tenants with stale legacy progressing state and for legacy progressing-only tenants.

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit (fmt-check + clippy + test + console-lint + console-fmt-check)
  • Added/updated necessary tests
  • Documentation updated (if needed)
  • CHANGELOG.md updated under [Unreleased] (if user-visible change)
  • CI/CD passed (if applicable)

Impact

  • Breaking change (CRD/API compatibility)
  • Requires doc/config/deployment update
  • Other impact: fixes Console topology health classification for tenants carrying stale legacy status.

Verification

cargo fmt --all --check
cargo clippy --all-features -- -D warnings
cargo test --all
make e2e-check
cd console-web && CI=true pnpm install --offline --frozen-lockfile
cd console-web && ./node_modules/.bin/eslint .
cd console-web && ./node_modules/.bin/next build
cd console-web && ./node_modules/.bin/prettier --check "**/*.{ts,tsx,js,jsx,json,css,md}"

Additional Notes

CI=true make pre-commit was attempted. The Rust and e2e stages passed, then the command failed before running frontend scripts because the local Codex runtime pnpm dependency sync timed out while fetching registry tarballs. After restoring dependencies from the local pnpm cache, the equivalent frontend lint, build, and format checks above passed directly.


Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.

@GatewayJ GatewayJ marked this pull request as ready for review June 28, 2026 02:34
@GatewayJ GatewayJ added this pull request to the merge queue Jun 28, 2026
Merged via the queue into rustfs:main with commit 5affe69 Jun 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant