Skip to content

fix: render KMS backend label in closed select #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cxymds merged 4 commits into from
Sep 1, 2026
Merged

fix: render KMS backend label in closed select #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b0e06c
fix: render KMS backend label in closed select
reatang Aug 27, 2026
39bbc36
Merge remote-tracking branch 'origin/main' into reatang/magical-golic…
cxymds Sep 1, 2026
5b24bd8
test: cover KMS backend select labels
cxymds Sep 1, 2026
c9c0fb3
Merge remote-tracking branch 'origin/main' into reatang/magical-golic…
cxymds Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions app/(dashboard)/sse/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import { Field, FieldContent, FieldDescription, FieldGroup, FieldLabel } from "@
import { Input } from "@/components/ui/input"
import { Page } from "@/components/page"
import { PageHeader } from "@/components/page-header"
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "@/components/ui/select"
import { Select, SelectContent, SelectGroup, SelectItem, SelectTrigger, SelectValue } from "@/components/ui/select"
import { Spinner } from "@/components/ui/spinner"
import { Table, TableBody, TableCaption, TableCell, TableHead, TableHeader, TableRow } from "@/components/ui/table"
import { useSSE } from "@/hooks/use-sse"
Expand Down Expand Up @@ -993,7 +993,7 @@ export default function SSEPage() {
local: t("Local filesystem"),
"vault-kv2": t("HashiCorp Vault KV2"),
"vault-transit": t("HashiCorp Vault Transit Engine"),
static: t("Static single-key (built-in)"),
static: t("Static single-key (built-in, dev/testing only)"),
}
const mutationLocked = Boolean(activeMutation || statusError || loadingStatus)
const unsupportedKmsReadOnly = formState.backendType === "unsupported"
Expand Down Expand Up @@ -1229,17 +1229,19 @@ export default function SSEPage() {
</SelectValue>
</SelectTrigger>
<SelectContent>
{formState.backendType === "unsupported" ? (
<SelectItem value="unsupported" disabled>
{t("Unsupported KMS backend")}
<SelectGroup>
{formState.backendType === "unsupported" ? (
<SelectItem value="unsupported" disabled>
{t("Unsupported KMS backend")}
</SelectItem>
) : null}
<SelectItem value="local">{t("Local filesystem (dev/testing only)")}</SelectItem>
<SelectItem value="vault-kv2">{t("HashiCorp Vault KV2")}</SelectItem>
<SelectItem value="vault-transit">{t("HashiCorp Vault Transit Engine")}</SelectItem>
<SelectItem value="static">
{t("Static single-key (built-in, dev/testing only)")}
</SelectItem>
) : null}
<SelectItem value="local">{t("Local filesystem (dev/testing only)")}</SelectItem>
<SelectItem value="vault-kv2">{t("HashiCorp Vault KV2")}</SelectItem>
<SelectItem value="vault-transit">{t("HashiCorp Vault Transit Engine")}</SelectItem>
<SelectItem value="static">
{t("Static single-key (built-in, dev/testing only)")}
</SelectItem>
</SelectGroup>
</SelectContent>
</Select>
</FieldContent>
Expand Down
10 changes: 10 additions & 0 deletions tests/lib/sse-safety.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,16 @@ test("unsupported KMS backends fail closed and require a current baseline before
assert.match(source, /setConfigBaselineConflict\(null\)/)
})

test("KMS backend select renders translated labels before its popup opens", () => {
assert.match(source, /"vault-transit": t\("HashiCorp Vault Transit Engine"\)/)
assert.match(source, /static: t\("Static single-key \(built-in, dev\/testing only\)"\)/)
assert.match(
source,
/<SelectValue placeholder=\{t\("Select backend type"\)\}>\s*\{backendTypeLabels\[formState\.backendType\] \?\? null\}\s*<\/SelectValue>/,
)
assert.match(source, /<SelectContent>\s*<SelectGroup>[\s\S]*<SelectItem value="vault-transit">/)
})

test("SSE form and dialogs stay reachable on narrow screens", () => {
assert.match(source, /<form\s+className="space-y-6"\s+noValidate/)
assert.match(source, /<fieldset className="space-y-4 border-t pt-4">/)
Expand Down