Skip to content

Conversation

@seijikun
Copy link
Contributor

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you please briefly describe in what scenarios this is used by you?

@seijikun
Copy link
Contributor Author

seijikun commented Nov 26, 2025

If I understood it correctly, this is basically the same as the special 0x00 (controller) address but from an older NVMe spec. I saw it in the smartmontools repo. Apparently, for some commands (like GET LOG PAGE == SMART), you are supposed to try both, to also be compatible with older NVMes.
It has a lot of mentions in the NVME spec, so I think it's a good idea to have it.

@phip1611 phip1611 added this pull request to the merge queue Nov 26, 2025
Merged via the queue into rust-osdev:main with commit 159f825 Nov 26, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants