Repository navigation
Constrain NativeMethod to Send + Sync - #367
Merged
martin-hughes merged 2 commits intoOct 8, 2026
Merged
Conversation
Contributor
Author
|
I'm reasonably happy that this is OK to merge, but I'll leave it here for a couple of days in case anyone spots any WTFs |
This makes Object Send + Sync, and by extension WrappedObject (although gain_mut is still a potential footgun). If rust-osdev#361 is merged as well, then Interpreter becomes Send + Sync without needing an `unsafe impl` block.
Updates since rust-osdev#361 got merged
martin-hughes
force-pushed
the
constrain-native-method
branch
from
October 4, 2026 10:29
f630d45 to
c523787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes Object Send + Sync, and by extension WrappedObject (although gain_mut is still a potential footgun). If #361 is merged as well, then
Interpreterbecomes Send + Sync without needing anunsafe implblock.I've manually tested that
Interpreterindeed becomes Send + Sync when #361 is merged.