Repository navigation
fix: Do unaligned reads for table entries - #364
Merged
Merged
Conversation
Contributor
|
Good spot, thanks @mkroening! I suspect you're right - I have a feeling that any of the raw pointer reads could be misaligned. I'll bear it in mind when I'm looking at things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After migrating Hermit to this crate, I faced some rare crashes in some configurations. Specifically, there are sometimes panics due to unaligned reads when reading table entries. As far as I know, this QEMU behavior is legal, since I could not find any alignment guarantees in the ACPI spec.
This PR fixes the specific issue that I hit. There might be other places in this crate, though, where alignment is incorrectly assumed.