-
Notifications
You must be signed in to change notification settings - Fork 159
Add f16, f128 #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add f16, f128 #333
Conversation
src/lib.rs
Outdated
| #![cfg_attr(feature = "f16", feature(f16))] | ||
| #![cfg_attr(feature = "f128", feature(f128))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not keen on maintaining for unstable features in this crate, so we're probably going to be blocked here until the language and standard library stabilize these new floats.
At that point, I think we'll probably want to have detection in the build script to enable it automatically, and Cargo features can force that on -- like we used to for has_i128.
c6e7689 to
dc38e4d
Compare
70e6d69 to
510dfa4
Compare
|
rust-lang/libs-team#707 would eventually rely on this (as per my implementation) so could we expedite support? |
I would not expect the standard library to start using (My reservations remain about unstable features as well.) |
integer_decodeis implemented forf128by truncating the radix to its 64 most significant bits. See Float::integer_decode cannot be implemented for quadruple precision floating types. #98.f128tests underno_stdandlibmfail.