Open
Conversation
Member
Author
|
Naming is hard -- this might be better with a longer name like |
d12c7de to
daf0e32
Compare
These are all of the numbers common to every primitive numeric type, available in constant form. Each value corresponds to its `usize` index. This could be seen as a replacement and extension of `ConstZero::ZERO` and `ConstOne::ONE` from `num-traits`, without worrying about the particulars of being additive/multiplicative identities. Here, we're just describing this as a workaround for the lack of generic literals.
Member
Author
|
I'm having second thoughts about this, because the array access doesn't get optimized in the front end like I hoped. In the It's better when that's forced to compile time, e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are all of the numbers common to every primitive numeric type,
available in constant form. Each value corresponds to its
usizeindex.This could be seen as a replacement and extension of
ConstZero::ZEROand
ConstOne::ONEfromnum-traits, without worrying about theparticulars of being additive/multiplicative identities. Here, we're
just describing this as a workaround for the lack of generic literals.