Fix issue #157: Display negative imaginary component#158
Open
Astronomy487 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #157. The original implementation of
Displaychecks what sign is needed between the real and imaginary components by comparing the imaginary component toT::zero(). This fails for negative-zero, which should be treated as negative but not less than zero, producing2+-0iwhen it should produce2-0i.This fix replaces a comparison against
T::zero()with theis_negativemethod. This fix replaces the trait bound ofPartialOrdwith a trait bound ofSigned. Technically can break people's custom types that implementPartialOrdbut notSigned. Added an appropriate test totest_string_formatting.