Add Missing MulAdd trait implementations for combination of Complex and Reals #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcapriot
commented
Nov 12, 2025
| Complex::new(re, im) | ||
| } | ||
| } | ||
| impl<'a, 'b, T: Clone + Num + MulAdd<Output = T>> MulAdd<&'b T, &'b Complex<T>> for &'a Complex<T> { |
Author
There was a problem hiding this comment.
My only question to someone more versed in lifetimes: should each of the reference to the input have the same lifetime parameter, or should there be three lifetimes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing three implementations for mixed Complex and Real
MulAddtrait.I see it was noted in #37 that there would be 8 total, and you did not want to support all of them, but because you can't implement the traits
for T(TnorMulAddare both external to the crate), there's only 4 total to implement here (1 of the 8 is implicitly MulAdd<T, T> for T).