perf(iteration): use move instead of clone for iteration#1586
Merged
akern40 merged 2 commits intorust-ndarray:masterfrom Feb 16, 2026
Merged
perf(iteration): use move instead of clone for iteration#1586akern40 merged 2 commits intorust-ndarray:masterfrom
akern40 merged 2 commits intorust-ndarray:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@scho-furiosa pointed out in #1584 that there was an unnecessary
cloneinBaseiter::nextthat was degrading performance for dynamic-dimensional arrays. This change switches to a move, netting a 74% speedup in iteration for dynamic-dimensional arrays.Tests (detailed in #1584) showed that there was a trade-off in performance between dynamic- and fixed-dimensional iteration.
ArrayDperforms best when mutating its index;ArrayNperforms best when using a move. This is an indication that, in the future,Baseiter::nextshould dispatch to the "layout" /Dimensionunderlying type.