-
Notifications
You must be signed in to change notification settings - Fork 309
Fix Simple Chinese translation for security && governance page #2228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: this needs WG-security-response to approve. Like #1996 (a previous attempt at translating this to zh-CN), I can offer to review if WG-security-response is on-board with that.
Like @cuviper said in #1996 (comment), we may also want to explicitly add a disclaimer that the English version is the only authoritative version.
Maybe we should add a note to temper expectations? Something like, "This policy translation is provided for convenience only -- the official policy is in English here (link)."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jieyouxu I'm happy to trust your approvals of Chinese translations!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jieyouxu Screenshot of https://rust-lang.org/zh-CN/policies/security
jieyouxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation. Looks accurate for the most part, I left only a few nits.
| governance-team-launching-pad-description = 团队的临时家园 | ||
| governance-team-leadership-council-name = 领导委员会 | ||
| governance-team-leadership-council-description = 负责整个 Rust 项目的成功,由顶级团队的代表组成 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit (style): missing trailing newline :D
Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com>
Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com>
Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com>
Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com>
Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com>
jieyouxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The zh-CN translation content LGTM now, thanks
|
(This presumably would supersede #1996.) |
No description provided.