Repository navigation
fix(test): fix rustup-init binary detection in fixture - #5211
Merged
Merged
Conversation
rami3l
force-pushed
the
fix/fixture-new-cargo
branch
from
November 13, 2026 10:38
9962032 to
ef6eb5a
Compare
rami3l
marked this pull request as ready for review
November 13, 2026 10:52
rami3l
force-pushed
the
fix/fixture-new-cargo
branch
from
November 13, 2026 11:21
ef6eb5a to
1fceb1d
Compare
djc
approved these changes
Nov 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #5210 (comment).
Problem Description
Cargo shipped in Rust v1.100.0 has broken our test fixture (but in a good way), as the artifact directory is now hashed like so:
... this causes the existing logic to lose track of where
rustup-init[EXE]should be for the tests going on.Proposed Solution
This patch uses the
CARGO_BIN_EXE_rustup-initenvironment variable to detect the location of therustup-initbinary used in the fixture, which is a more stable approach than the current dirname exclusion-based one. It works consistently with both Rust v1.100.0 and earlier versions.Future Work
Since the artifact directory is now hashed, I don't think it makes any more sense to store the temporary (mock) Rust installations alongside the artifacts. So I am thinking about maybe putting them into the OS' tmp dir instead, hoping to further reduce the size of
./targetthis way. This optimization can be done in a later patch.