Conversation
Cloud0310
force-pushed
the
install-state
branch
from
September 21, 2026 12:42
373ad72 to
ce17bc7
Compare
This comment has been minimized.
This comment has been minimized.
djc
reviewed
Sep 21, 2026
Cloud0310
force-pushed
the
install-state
branch
from
September 21, 2026 13:43
ce17bc7 to
a672820
Compare
Member
|
@djc I would like to provide some extra context regarding this part of the changes: it has been a follow-up of my request #5091 (comment) in a previous attempt of decoupling the rcfile-related logic from This is needed because the new uninstallation logic will attempt to remove the rcfile entries from both the |
djc
approved these changes
Sep 21, 2026
rami3l
reviewed
Sep 21, 2026
Cloud0310
force-pushed
the
install-state
branch
from
September 22, 2026 06:13
a672820 to
80f5e77
Compare
This comment has been minimized.
This comment has been minimized.
Cloud0310
force-pushed
the
install-state
branch
from
September 22, 2026 11:53
80f5e77 to
6035ddd
Compare
Pass bin directories to binary, proxy, and updater helpers, and pass the resolved Cargo home to Windows uninstall GC. Give shell script helpers separate env and bin directory inputs while preserving legacy home-variable spelling.
Pass resolved env and user-home paths into source-line rendering. Share exact source-line removal and reuse the current operation paths and legacy rcfile candidates during cleanup.
Cloud0310
force-pushed
the
install-state
branch
from
September 22, 2026 11:57
6035ddd to
3abfe34
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@rami3l seems there's an error upon CI/CD, and it's not due my code. Could you re-run it? And leaving alone the part of |
Cloud0310
force-pushed
the
install-state
branch
from
September 22, 2026 13:28
ff59d0b to
f9994e1
Compare
rami3l
approved these changes
Sep 22, 2026
Keep canonical_cargo_home and accept resolved paths without renaming it. Pass complete bin and env directory text to the templates, share post-install wording across platforms, and reuse the resolved homes for source commands. Keep display formatting separate from filesystem paths and use native separators in the uninstall message.
Cloud0310
force-pushed
the
install-state
branch
from
September 22, 2026 14:49
f9994e1 to
0a1873f
Compare
Contributor
Author
|
Fixed all of them @rami3l . |
Cloud0310
force-pushed
the
install-state
branch
from
September 22, 2026 15:49
0a1873f to
f592400
Compare
Cloud0310
force-pushed
the
install-state
branch
from
September 22, 2026 16:06
f592400 to
2468895
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5091 was not a complete decouple of
Process's state from the related install/uninstall helpers.So, this PR does:
Cowusage ofcargo_home_str_with_home,cargo_home_str, as the caller immediately constructsStringProcess' states, e.g.cargo_homeand other, allowing for re-using the resolution result.remove_legacy_source_command, as the same logic is already done indo_remove_from_pathIn the meantime, this the first of a series of refactors around uninstall/install/self-replacing logic.