Skip to content

Suggest alternative toolchains for unavailable targets - #5094

Open
Sreehari425 wants to merge 1 commit into
rust-lang:mainfrom
Sreehari425:rustup-msg
Open

Sreehari425 wants to merge 1 commit into
rust-lang:mainfrom
Sreehari425:rustup-msg

Conversation

@Sreehari425

Copy link
Copy Markdown
Contributor

Closes #4164

rustup target remove <target> now suggests another installed toolchain when the target isn't available in the current one. If no other toolchain has the target, the existing error is unchanged.

Comment thread src/toolchain/distributable.rs
Comment thread src/errors.rs Outdated
Comment thread src/toolchain/distributable.rs Outdated
Comment thread src/toolchain/distributable.rs Outdated
@Sreehari425
Sreehari425 force-pushed the rustup-msg branch 4 times, most recently from 3d12360 to c6e412e Compare September 19, 2026 12:31
@rustbot

This comment has been minimized.

Comment thread src/toolchain/distributable.rs Outdated
Comment thread src/toolchain/distributable.rs Outdated
Comment thread src/toolchain/distributable.rs Outdated
Comment thread src/errors.rs Outdated
@rustbot

This comment has been minimized.

@djc

djc commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Uh, this seems to have a bunch of unrelated changes, and lost the useful commit history split in the process.

@Sreehari425

Copy link
Copy Markdown
Contributor Author

Uh, this seems to have a bunch of unrelated changes, and lost the useful commit history split in the process.

yeah you are right sorry. I was trying to make the target changes into one clean commit and accidentally pulled the unrelated changes into it too. I messed up the history, fixing it now rn

@rustbot

rustbot commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Sreehari425

Copy link
Copy Markdown
Contributor Author

@djc thanks for reviewing this earlier :), i have addressed the issues you pointed out and cleaned up the changes would appreciate another look when you get a chance.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggest another toolchain when removing a component/target unavailable to the current toolchain

4 participants