fix(cli/rustup_mode)!: skip auto-installation in some rustup commands#4840
Draft
rami3l wants to merge 2 commits intorust-lang:mainfrom
Draft
fix(cli/rustup_mode)!: skip auto-installation in some rustup commands#4840rami3l wants to merge 2 commits intorust-lang:mainfrom
rustup commands#4840rami3l wants to merge 2 commits intorust-lang:mainfrom
Conversation
rami3l
force-pushed
the
fix/skip-auto-install
branch
from
4892599 to
8ab1b84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4836 by making it possible to skip
should_auto_install's dynamic detection entirely.Whether the skip should be applied can be predetermined during
clapdispatch (at least forrustup_mode.rs), so the only remaining question seems to be where we would want to apply the skip.