fix: preserve closure receivers for postfix chains - #7013
Open
mgalore wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
ytmimi
requested changes
Aug 5, 2026
Contributor
There was a problem hiding this comment.
We can't just flip this from false to true for all of the variants listed It doesn't apply for ExprKind::Try. Also, as I mentioned in #7011 (comment) we should consider renaming is_method_call_receiver since that doesn't really apply now that we're also using that field for field, await, use, and postfix yield.
Comment on lines
+524
to
+530
| | ast::ExprKind::Yield(ast::YieldKind::Postfix(ref subexpr)) => Some(SubExpr { | ||
| expr: Self::convert_try(subexpr, context), | ||
| is_method_call_receiver: false, | ||
| is_method_call_receiver: true, |
Contributor
There was a problem hiding this comment.
I don't think this is supposed to apply to ast::ExprKind::Try
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
mgalore
force-pushed
the
fix/7011-range-postfix
branch
from
August 5, 2026 18:06
5f4446c to
688ff00
Compare
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7011.
Testing
cargo testRUSTFLAGS="-D warnings" cargo testcargo run --bin rustfmt -- --check src/chains.rsgit diff --check