use core fallbacks for more f16/f128 operations#910
Merged
Conversation
antoyo
reviewed
Jul 16, 2026
folkertdev
force-pushed
the
use-float-fallbacks
branch
from
July 16, 2026 18:05
d4c83de to
c24a53f
Compare
folkertdev
force-pushed
the
use-float-fallbacks
branch
from
July 16, 2026 18:08
c24a53f to
75f5d18
Compare
antoyo
approved these changes
Jul 16, 2026
Contributor
|
Nice improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some explicit handling of functions that since rust-lang/rust#150946 have a fallback via libm.
We plan to do this for more operations (especially for
f16, where possible forf128) to be able to remove custom logic from the backends.