Avoid the arena_cache modifier for several queries

[Zalathar]

The arena_cache query modifier is convenient, but we can potentially avoid some overhead by allocating values into the central tcx.arena when possible.

There should be no change to compiler output.

[Zalathar]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 6f7d022 (6f7d022409d054eabfd477aad3fabdfbd1d91cbc)
Base parent: 7022271 (70222712809cd5cc1718ed8995914a1cbacb6b92)

[rust-timer]

Finished benchmarking commit (6f7d022): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	0.1%	[0.1%, 0.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	5
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Max RSS (memory usage)

Results (primary -1.3%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	3.4%	[0.8%, 6.7%]	9
Improvements ✅ (primary)	-1.5%	[-3.4%, -0.7%]	10
Improvements ✅ (secondary)	-2.0%	[-3.2%, -0.8%]	13
All ❌✅ (primary)	-1.3%	[-3.4%, 1.1%]	11

Cycles

Results (primary 2.4%, secondary 7.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	7.9%	[2.1%, 13.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.4%	[2.4%, 2.4%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 475.539s -> 474.177s (-0.29%)
Artifact size: 400.59 MiB -> 400.51 MiB (-0.02%)