Update more math intrinsics to use LLVM instead of libm - #162104
Draft
ZuseZ4 wants to merge 2 commits into
Draft
Conversation
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
Zulip discussion starting at #general > algebraic float ops @ 💬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a prototype to be discussed on zulip. If accepted I'd update miri, f16/f128, clean it up, and add the other ones
tan, asin, acos, atan, sinh, cosh.Motivation: For HPC/Scientific Computing Benchmarks I often port existing C/C++ code to Rust and compare how they fare. When looking at IR differences, these often came up. C++ has the
-fno-math-errnoflag, but we explicitly don't guarantee which implementation we use, so I think we are free (and should) default to this behaviour which allows more optimizations.