small refactor of doc attribute arguments warnings - #162099
Open
mejrs wants to merge 2 commits into
Open
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
rustbot
added
the
T-rustdoc
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| ); | ||
| } | ||
| ArgParser::List(items) => { | ||
| ArgParser::List(items) if !items.is_empty() => { |
Member
There was a problem hiding this comment.
Hmmm I'm not sure how I feel about a INVALID_DOC_ATTRIBUTES on #[doc()], could you motivate this change?
I think UNUSED_ATTRIBUTES might be nicer.
Other attributes, such as #[repr()], #![feature()] also do this.
JonathanBrouwer
requested changes
Sep 1, 2026
rustbot
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.