Skip to content

FileCheck uninhabited_fallthrough_elimination - #162096

Open
joseph-isaacs wants to merge 1 commit into
rust-lang:mainfrom
joseph-isaacs:ji/filecheck-uninhabited-fallthrough-elim
Open

FileCheck uninhabited_fallthrough_elimination#162096
joseph-isaacs wants to merge 1 commit into
rust-lang:mainfrom
joseph-isaacs:ji/filecheck-uninhabited-fallthrough-elim

Conversation

@joseph-isaacs

@joseph-isaacs joseph-isaacs commented Aug 31, 2026

Copy link
Copy Markdown

FileCheck uninhabited_fallthrough_elimination seems to be missing test-mir-pass: UnreachableEnumBranching so it was added.

The check assert that only the basic blocks expected are in the switchInt and for each BB that the return value is assigned in that bb.

r? cjgillot

part of #116971

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 31, 2026
@rustbot

rustbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project has assigned @mejrs (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 18 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants