Skip to content

CheckFile GVN array access - #162095

Open
joseph-isaacs wants to merge 1 commit into
rust-lang:mainfrom
joseph-isaacs:ji/filecheck-large-array-index-gvn
Open

CheckFile GVN array access#162095
joseph-isaacs wants to merge 1 commit into
rust-lang:mainfrom
joseph-isaacs:ji/filecheck-large-array-index-gvn

Conversation

@joseph-isaacs

@joseph-isaacs joseph-isaacs commented Aug 31, 2026

Copy link
Copy Markdown

GVN replaced const prop and this can symbolically evaluate [0_u8; 5000][2] = 0u8.

This PR asserts this

r? cjgillot

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 31, 2026
@rustbot

rustbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project has assigned @ShoyuVanilla (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

// check that gvn access repeat inner.
// CHECK-LABEL: fn main(
// CHECK: debug x => [[x:_.*]];
// CHECK: assert(const true,

@joseph-isaacs joseph-isaacs Aug 31, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to this to include the "index out of bounds: text in case it changes?

View changes since the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants