compiler-builtins subtree update - #162077
Open
folkertdev wants to merge 30 commits into
Open
Conversation
The git registry now takes long enough to download that the 10 minute timeout is hit.
Since 1.97, linker warnings can be denied via rustc.
This is the first version with LLVM23.
This was added as part of the original test infrastructure at
8e161a791a89 ("Expand and refactor teting infrastructure") but there
doesn't seem to be any reason to keep this restriction; qemu should
handle the threads fine.
With LLVM 23, containing f128 abi fixes, this now works
Benchmarks are designed to run in release mode so these can be pretty slow. Running once with `release-checked` is sufficient.
Fixes rust-lang/compiler-builtins#1271 by removing `#[aapcs_on_arm]`: `compiler-rt` only does the equivalent on ARM soft-float targets where the `"C"` ABI is already AAPCS. [ add PR description to commit - Trevor ]
This updates the rust-version file to f7d782a.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@f7d782a Filtered ref: rust-lang/compiler-builtins@1ebbb4d Upstream diff: rust-lang/rust@2c39ff4...f7d782a This merge was created using https://github.com/rust-lang/josh-sync.
Some PRs want to make use of newer features.
This reverts commit 4feca6f3e62151f5cedacf3a5877b6200fb5af43. The patch has landed in the 23.1-2026-07-22 branch.
This should make it fall back to a system-wide cargo-nextest install or running the tests without nextest, which is probably still faster than building nextest from source.
This error started appearing in the latest nightly:
error: the loop variable `i` is used to index `ret.0`
--> builtins-test/tests/mem.rs:149:14
|
149 | for i in 0..N {
| ^^^^
|
note: for this index operation
--> builtins-test/tests/mem.rs:150:9
|
150 | ret.0[i] = i as u8;
| ^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/main/index.html#needless_range_loop
= note: `-D clippy::needless-range-loop` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_range_loop)]`
help: consider using an iterator and `.enumerate()`
|
149 - for i in 0..N {
149 + for (i, <item>) in ret.0.iter_mut().enumerate().take(N) {
|
Prepare for reuse elsewhere.
Prepare for reuse elsewhere.
Remove a mostly redundant type. There are some minor differences in the `memcmp` benches because the slices are now the same length (`let s2: &[u8] = black_box(&v2[1..]);` was trimming one).
We'd like to this add new `s390x` runner to `compiler-builtins`. This new runner is provided by Canonical. After some iteration alongside with Canonical folks, the `large` runner offers hardware spec similar to the existing s390x provided by IBM and [delivers similar build times](https://github.com/rust-lang/compiler-builtins/actions/runs/31516313575/job/93862267593?pr=1227). Moreover, it runs on ubuntu-26.04 rather than ubuntu-24.04, and it features a Github integration more friendly to `t-infra`, since the related Github App requires less permissions to run. We don't need to remove the s390x IBM runners right now. We propose having both s390x runners running side by side for a while and circle back after a few PRs, sticking with the Canonical one afterwards if everything goes well.
There doesn't seem to be a straightforward way to build and test this target anymore. Disable it for now since CI is broken. Link: rust-lang/compiler-builtins#1306
This updates the rust-version file to 45f215f.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 45f215f Filtered ref: 2e55b234943f43e4b52bbfba006744b9a4318124 Upstream diff: rust-lang/rust@f7d782a...45f215f This merge was created using https://github.com/rust-lang/josh-sync.
rustbot
added
the
T-libs
folkertdev
marked this pull request as ready for review
August 31, 2026 20:18
Collaborator
|
cc @tgross35 |
rustbot
added
S-waiting-on-review
Collaborator
|
Contributor
Author
|
@bors r+ p=1 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 31, 2026
…2026-09-31, r=folkertdev compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@9eed682. Created using https://github.com/rust-lang/josh-sync. r? @ghost
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 31, 2026
…2026-09-31, r=folkertdev compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@9eed682. Created using https://github.com/rust-lang/josh-sync. r? @ghost
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 31, 2026
…2026-09-31, r=folkertdev compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@9eed682. Created using https://github.com/rust-lang/josh-sync. r? @ghost
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
…uwer Rollup of 12 pull requests Successful merges: - #162045 (`rust-analyzer` subtree update) - #162077 (compiler-builtins subtree update) - #137720 (support `#[target_feature(enable = ...)]` on `#[naked]` functions) - #160534 (stabilize smart pointer map functions) - #160551 (mir_build: Clearly distinguish or/refutable/irrefutable patterns during match lowering) - #161929 (explicitly track inherent const generic args kind) - #162063 (Switch dist-aarch64-linux to EC2 and update dist-x86_64-linux) - #161937 (A series of Polonius Alpha refactors) - #162014 (Move more `rustdoc-html` tests using `--test` into the right folder) - #162051 (`rustc_feature` cleanups) - #162055 (remove `_{style}` recovery for diagnostic structs) - #162075 (Move track_caller on closures gating to attribute parsing)
Contributor
Author
|
I suspect this PR is the cause of #162089 (comment), because the subtree update makes changes to float libcalls. Anyhow, can't hurt to just check that. @bors r- |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#162089), which was unapproved. |
Contributor
Author
|
@bors try jobs=armhf-gnu |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
… r=<try> compiler-builtins subtree update try-job: armhf-gnu
Contributor
Author
|
I've now reproduced the failure locally, cc @beetrees Apparently f16 is special. The comment here seems to confirm that
And that does appear to be happening, e.g. https://godbolt.org/z/4EfavG1Px in the |
Contributor
|
💔 Test for aa5454a failed: CI. Failed job:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
@bors rollup=never |
Member
|
In reviewing rust-lang/compiler-builtins@11eda6a think I overlooked that |
Member
|
LLVM is doing the right codegen but their logic isn't correct. Patches in the works... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtree update of
compiler-builtinsto rust-lang/compiler-builtins@9eed682.Created using https://github.com/rust-lang/josh-sync.
r? @ghost