Skip to content

Change some Infallible to ! in std - #162073

Open
camsteffen wants to merge 1 commit into
rust-lang:mainfrom
camsteffen:lib-eat-never
Open

Change some Infallible to ! in std#162073
camsteffen wants to merge 1 commit into
rust-lang:mainfrom
camsteffen:lib-eat-never

Conversation

@camsteffen

@camsteffen camsteffen commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

I believe this desirable since we recommend ! over Infallible, so std follows its own advice. Most changes are to unstable features, but not all. Similar changes in compiler have to wait for a bootstrap update.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 31, 2026
@rustbot

rustbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

r? @clarfonthey

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from JohnTitor, Mark-Simulacrum, clarfonthey, joboet, nia-e

@clarfonthey

clarfonthey commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Thank you!

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8e9bc25 has been approved by clarfonthey

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@clarfonthey

clarfonthey commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@bors r-

(I thought that would be automatic, honestly.)

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 31, 2026
@rust-bors

rust-bors Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 31, 2026
@camsteffen

camsteffen commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

I fixed the rustdoc test and it looks reasonable but I'm not very familiar with that.

@camsteffen

camsteffen commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

(I thought that would be automatic, honestly.)

Got me curious so I found rust-lang/bors#317

@clarfonthey

clarfonthey commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

I fixed the rustdoc test and it looks reasonable but I'm not very familiar with that.

Mentioned it on Zulip to see if anyone has comments: #t-rustdoc > never_search test @ 💬

@camsteffen

camsteffen commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2026
@clarfonthey

clarfonthey commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

Thank you! Got confirmation that the never_search test is indeed just checking for searches to never, and that showing up with new impls is fine.

@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 49736a2 has been approved by clarfonthey

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2026
MusicalNinjaDad
MusicalNinjaDad reviewed Sep 1, 2026
View reviewed changes

@MusicalNinjaDad MusicalNinjaDad left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I'd just done something similar but smaller scoped :)

View changes since this review

Comment thread library/alloc/src/bstr.rs Outdated
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2026
@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

⚠️ A new commit dd132214ed3e2415da4292fec21f564f4496baa5 was pushed.

This pull request was unapproved.

@rustbot rustbot added the A-rustdoc-js Area: Rustdoc's JS front-end label Sep 1, 2026
@rustbot rustbot added A-rustdoc-search Area: Rustdoc's search feature T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 1, 2026
@rustbot

rustbot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clarfonthey clarfonthey clarfonthey left review comments
+1 more reviewer
@MusicalNinjaDad MusicalNinjaDad MusicalNinjaDad left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@clarfonthey clarfonthey

Labels

A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@camsteffen @rustbot @clarfonthey @rust-log-analyzer @MusicalNinjaDad