Skip to content

Move compiletest CLI parsing to cli.rs#159500

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kobzol:compiletest-move-cli
Jul 18, 2026
Merged

Move compiletest CLI parsing to cli.rs#159500
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kobzol:compiletest-move-cli

Conversation

@Kobzol

@Kobzol Kobzol commented Jul 18, 2026

Copy link
Copy Markdown
Member

Separated out of #159451.

@rustbot

rustbot commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc labels Jul 18, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 18, 2026
@rustbot

rustbot commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
  • @jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu, oli-obk, wesleywiser

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me after one nit

View changes since this review

Comment thread src/tools/compiletest/src/cli.rs Outdated
@rust-log-analyzer

This comment has been minimized.

@Kobzol
Kobzol force-pushed the compiletest-move-cli branch from f01d92c to d75ce78 Compare July 18, 2026 07:17
@Kobzol
Kobzol force-pushed the compiletest-move-cli branch from d75ce78 to 01c4242 Compare July 18, 2026 07:19
@rustbot

rustbot commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

@Kobzol

Kobzol commented Jul 18, 2026

Copy link
Copy Markdown
Member Author

@bors r=jieyouxu rollup

@rust-bors

rust-bors Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 01c4242 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 18, 2026
…youxu

Move compiletest CLI parsing to `cli.rs`

Separated out of rust-lang#159451.
rust-bors Bot pushed a commit that referenced this pull request Jul 18, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic)
 - #158545 (Move `std::io::read_to_string` to `alloc::io`)
 - #159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test)
 - #159470 (Fix string indexing in diagnostic format strings)
 - #159500 (Move compiletest CLI parsing to `cli.rs`)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 18, 2026
…youxu

Move compiletest CLI parsing to `cli.rs`

Separated out of rust-lang#159451.
rust-bors Bot pushed a commit that referenced this pull request Jul 18, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #159467 (Add explicit `Iterator::count` impl for `str::EncodeUtf16`)
 - #158545 (Move `std::io::read_to_string` to `alloc::io`)
 - #159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test)
 - #159470 (Fix string indexing in diagnostic format strings)
 - #159500 (Move compiletest CLI parsing to `cli.rs`)
rust-bors Bot pushed a commit that referenced this pull request Jul 18, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #159425 (Windows: add context when opening NUL for child stdio fails)
 - #159467 (Add explicit `Iterator::count` impl for `str::EncodeUtf16`)
 - #157860 (Move rustdoc run-make tests into new `tests/run-make/rustdoc/`)
 - #158545 (Move `std::io::read_to_string` to `alloc::io`)
 - #159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test)
 - #159459 (Detect when trait bound requires closure to return itself)
 - #159470 (Fix string indexing in diagnostic format strings)
 - #159500 (Move compiletest CLI parsing to `cli.rs`)
@rust-bors
rust-bors Bot merged commit 2fa71af into rust-lang:main Jul 18, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 18, 2026
rust-timer added a commit that referenced this pull request Jul 18, 2026
Rollup merge of #159500 - Kobzol:compiletest-move-cli, r=jieyouxu

Move compiletest CLI parsing to `cli.rs`

Separated out of #159451.
@Kobzol
Kobzol deleted the compiletest-move-cli branch July 18, 2026 20:49
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 20, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#159425 (Windows: add context when opening NUL for child stdio fails)
 - rust-lang/rust#159467 (Add explicit `Iterator::count` impl for `str::EncodeUtf16`)
 - rust-lang/rust#157860 (Move rustdoc run-make tests into new `tests/run-make/rustdoc/`)
 - rust-lang/rust#158545 (Move `std::io::read_to_string` to `alloc::io`)
 - rust-lang/rust#159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test)
 - rust-lang/rust#159459 (Detect when trait bound requires closure to return itself)
 - rust-lang/rust#159470 (Fix string indexing in diagnostic format strings)
 - rust-lang/rust#159500 (Move compiletest CLI parsing to `cli.rs`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants