Implement to_string() on ByteStr and ByteString#159300
Draft
DanielEScherzer wants to merge 3 commits into
Draft
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
but why? |
Contributor
Author
For #134915 but I wasn't going to link it until I got CI to pass |
Member
|
hmm. see also #134915 (comment) |
DanielEScherzer
force-pushed
the
bytestr-to-string
branch
from
c9b6c8c to
91ae0c4
Compare
Member
also for note this is a totally reasonable thing to do, sorry to bother, I only asked because the PR kind of made me do a double-take ("but ByteStr isn't even stable...?") |
DanielEScherzer
force-pushed
the
bytestr-to-string
branch
from
91ae0c4 to
06765dd
Compare
DanielEScherzer
changed the title
to_string() on ByteStr and ByteStringto_string() on ByteStr and ByteString
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.