Always generate private and hidden items in JSON docs of the stdlib by Kobzol · Pull Request #159188 · rust-lang/rust

Kobzol · 2026-07-12T19:03:05Z

This data is needed for downstream tools, e.g. cargo-semver-checks, to analyse the whole stdlib.

For the HTML output it is configurable using build.library-docs-private-items, but to avoid adding a separate config for just the JSON format, I think that we can just enable it unconditionally.

An alternative would be to change the flag from a bool to something like

enum StdDocsPrivateItems {
    No,
    Yes,
    Html,
    Json
}

rustbot · 2026-07-12T19:03:10Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: bootstrap
bootstrap expanded to 6 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

Mark-Simulacrum · 2026-07-18T19:18:07Z

@bors r+ rollup=iff

Probably has some implications for shipping these on stable/beta channels (though not sure that it's a blocker), but seems reasonable.

rust-bors · 2026-07-18T19:18:10Z

Invalid command: Invalid rollup mode iff. Possible values are always/iffy/never/maybe. Run @bors help or go to https://bors.rust-lang.org/help to see available commands.

Mark-Simulacrum · 2026-07-18T19:18:14Z

@bors rollup=iffy r+

Mark-Simulacrum · 2026-07-18T21:56:13Z

@bors r+ rollup=iffy

rust-bors · 2026-07-18T21:56:15Z

📌 Commit d9466af has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…k-Simulacrum Always generate private and hidden items in JSON docs of the stdlib This data is needed for downstream tools, e.g. cargo-semver-checks, to analyse the whole stdlib. For the HTML output it is configurable using `build.library-docs-private-items`, but to avoid adding a separate config for just the JSON format, I think that we can just enable it unconditionally. An alternative would be to change the flag from a bool to something like ```rust enum StdDocsPrivateItems { No, Yes, Html, Json } ```

Rollup of 3 pull requests Successful merges: - #159188 (Always generate private and hidden items in JSON docs of the stdlib) - #158546 (Move `std::io::BufRead` to `alloc::io`) - #159372 (Remove SIZE generic param from DisplayBuffer in core::net)

jhpratt · 2026-07-19T07:33:08Z

Looks like we need a drive-by change to fix a trivial lint.

@bors r- #159546 (comment)

warning: this URL is not a hyperlink
   --> library/std_detect/src/detect/os/linux/aarch64.rs:261:9
    |
261 |     /// https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AArch64/AArch64.td
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: bare URLs are not automatically turned into clickable links
    = note: `#[warn(rustdoc::bare_urls)]` on by default
help: use an automatic link instead
    |
261 |     /// <https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AArch64/AArch64.td>
    |         +                                                                                 +

rust-bors · 2026-07-19T07:33:14Z

This pull request was unapproved.

This PR was contained in a rollup (#159546), which was unapproved.

View changes since this unapproval

Kobzol · 2026-07-19T08:23:01Z

Oh, that's interesting. Looks like actually documenting private/hidden docs on CI also helps catch bugs in docs!

rustbot · 2026-07-19T08:44:10Z

Some changes occurred in std_detect

cc @Amanieu, @folkertdev, @sayantn

Kobzol · 2026-07-19T08:44:11Z

@bors try jobs=dist-aarch64-linux

I tried x dist rust-doc-json and it went through. Let's test on CI.

Always generate private and hidden items in JSON docs of the stdlib try-job: dist-aarch64-linux

rust-bors · 2026-07-19T11:06:06Z

☀️ Try build successful (CI)
Build commit: 7143f4c (7143f4c1acac6ee5ed85b0d897b7ee7a92d7cb3a)
Base parent: c904ba3 (c904ba32e22c9d6fd31140b4283c5cc6c6b2fb5c)

Kobzol · 2026-07-19T12:29:26Z

Fixed the CI failure.

@bors r=Mark-Simulacrum rollup=iffy

rust-bors · 2026-07-19T12:29:29Z

📌 Commit c84d862 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

rust-bors · 2026-07-19T15:31:29Z

💔 Test for e4ac328 failed: CI. Failed job:

auto - aarch64-msvc-1 (web logs, enhanced plaintext logs)

Mark-Simulacrum · 2026-07-19T16:43:21Z

@bors retry

@bors try jobs=aarch64-msvc-1

I'm hoping that debuginfo-cdb] tests\debuginfo\basic-stepping.rs#opt-level-0 isn't failing due to this PR.

Always generate private and hidden items in JSON docs of the stdlib try-job: arch64-msvc-1

Always generate private and hidden items in JSON docs of the stdlib try-job: aarch64-msvc-1

rust-bors · 2026-07-19T18:59:06Z

☀️ Try build successful (CI)
Build commit: 81e6674 (81e6674494994e913afc3cea1ca2111a93a7e02e)
Base parent: 234c31c (234c31cd674e11703f15d290cba7ff81dfe8b4b8)

…k-Simulacrum Always generate private and hidden items in JSON docs of the stdlib This data is needed for downstream tools, e.g. cargo-semver-checks, to analyse the whole stdlib. For the HTML output it is configurable using `build.library-docs-private-items`, but to avoid adding a separate config for just the JSON format, I think that we can just enable it unconditionally. An alternative would be to change the flag from a bool to something like ```rust enum StdDocsPrivateItems { No, Yes, Html, Json } ```

…uwer Rollup of 6 pull requests Successful merges: - #159188 (Always generate private and hidden items in JSON docs of the stdlib) - #159567 (Update rustc crate crossbeam-epoch to 0.9.20) - #150732 (Convert `-Ctarget-cpu` into a target-modifier for AVR, AMDGCN and NVPTX ) - #151793 (Add mul_add_relaxed methods for floating-point types) - #159549 (restrict const-eval-related 'content' triggers to library/ folder) - #159570 (fix ICE in opsem inhabitedness check)

…uwer Rollup of 5 pull requests Successful merges: - #159188 (Always generate private and hidden items in JSON docs of the stdlib) - #159567 (Update rustc crate crossbeam-epoch to 0.9.20) - #150732 (Convert `-Ctarget-cpu` into a target-modifier for AVR, AMDGCN and NVPTX ) - #159549 (restrict const-eval-related 'content' triggers to library/ folder) - #159570 (fix ICE in opsem inhabitedness check)

jhpratt · 2026-07-20T01:58:03Z

@bors try dist-x86_64-linux

Making sure this isn't an unexpected cause of #159579

rust-bors · 2026-07-20T01:58:06Z

Unknown argument "dist-x86_64-linux". Did you mean to use @bors jobs=<jobs>|parent=<parent>? Run @bors help or go to https://bors.rust-lang.org/help to see available commands.

jhpratt · 2026-07-20T01:58:13Z

@bors try jobs=dist-x86_64-linux

rust-bors · 2026-07-20T01:58:23Z

⌛ Trying commit c84d862 with merge f33fe6c…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/29711723531

Always generate private and hidden items in JSON docs of the stdlib try-job: dist-x86_64-linux

…uwer Rollup of 5 pull requests Successful merges: - #159188 (Always generate private and hidden items in JSON docs of the stdlib) - #159567 (Update rustc crate crossbeam-epoch to 0.9.20) - #150732 (Convert `-Ctarget-cpu` into a target-modifier for AVR, AMDGCN and NVPTX ) - #159549 (restrict const-eval-related 'content' triggers to library/ folder) - #159570 (fix ICE in opsem inhabitedness check)

Rollup merge of #159188 - Kobzol:rustdoc-json-private, r=Mark-Simulacrum Always generate private and hidden items in JSON docs of the stdlib This data is needed for downstream tools, e.g. cargo-semver-checks, to analyse the whole stdlib. For the HTML output it is configurable using `build.library-docs-private-items`, but to avoid adding a separate config for just the JSON format, I think that we can just enable it unconditionally. An alternative would be to change the flag from a bool to something like ```rust enum StdDocsPrivateItems { No, Yes, Html, Json } ```

jhpratt · 2026-07-20T06:33:46Z

Somehow the try job took longer than the actual run?

@bors try cancel

rust-bors · 2026-07-20T06:33:49Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/29711723531

Always generate private and hidden items in JSON docs of the stdlib

d9466af

rustbot assigned Mark-Simulacrum Jul 12, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 12, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2026

jhpratt mentioned this pull request Jul 19, 2026

Rollup of 3 pull requests #159546

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 19, 2026

Fix documentation in stdarch

c84d862

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 19, 2026

Auto merge of #159188 - Kobzol:rustdoc-json-private, r=<try>

7143f4c

Always generate private and hidden items in JSON docs of the stdlib try-job: dist-aarch64-linux

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2026

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 19, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 19, 2026

Auto merge of #159188 - Kobzol:rustdoc-json-private, r=<try>

fc083ff

Always generate private and hidden items in JSON docs of the stdlib try-job: arch64-msvc-1

This comment was marked as resolved.

Sign in to view

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 19, 2026

Auto merge of #159188 - Kobzol:rustdoc-json-private, r=<try>

81e6674

Always generate private and hidden items in JSON docs of the stdlib try-job: aarch64-msvc-1

JonathanBrouwer mentioned this pull request Jul 19, 2026

Rollup of 6 pull requests #159573

Closed

JonathanBrouwer mentioned this pull request Jul 19, 2026

Rollup of 5 pull requests #159579

Merged

rust-bors Bot pushed a commit that referenced this pull request Jul 20, 2026

Auto merge of #159188 - Kobzol:rustdoc-json-private, r=<try>

f33fe6c

Always generate private and hidden items in JSON docs of the stdlib try-job: dist-x86_64-linux

rust-bors Bot merged commit 1b823bd into rust-lang:main Jul 20, 2026
13 of 15 checks passed

rustbot added this to the 1.99.0 milestone Jul 20, 2026

Kobzol deleted the rustdoc-json-private branch July 20, 2026 06:30

Uh oh!

Uh oh!

Conversation

Kobzol commented Jul 12, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 12, 2026

Uh oh!

Mark-Simulacrum commented Jul 18, 2026

Uh oh!

rust-bors Bot commented Jul 18, 2026

Uh oh!

Mark-Simulacrum commented Jul 18, 2026

Uh oh!

Mark-Simulacrum commented Jul 18, 2026

Uh oh!

rust-bors Bot commented Jul 18, 2026

Uh oh!

jhpratt commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Jul 19, 2026

Uh oh!

Kobzol commented Jul 19, 2026

Uh oh!

rustbot commented Jul 19, 2026

Uh oh!

Kobzol commented Jul 19, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 19, 2026

Uh oh!

Kobzol commented Jul 19, 2026

Uh oh!

rust-bors Bot commented Jul 19, 2026

Uh oh!

rust-bors Bot commented Jul 19, 2026

Uh oh!

Mark-Simulacrum commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as resolved.

This comment has been minimized.

rust-bors Bot commented Jul 19, 2026

Uh oh!

jhpratt commented Jul 20, 2026

Uh oh!

rust-bors Bot commented Jul 20, 2026

Uh oh!

jhpratt commented Jul 20, 2026

Uh oh!

rust-bors Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jhpratt commented Jul 20, 2026

Uh oh!

rust-bors Bot commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kobzol commented Jul 12, 2026 •

edited by rustbot

Loading

jhpratt commented Jul 19, 2026 •

edited

Loading

Mark-Simulacrum commented Jul 19, 2026 •

edited

Loading

rust-bors Bot commented Jul 20, 2026 •

edited

Loading