Skip to content

Add proc_macro attribute documentation#158962

Open
josetorrs wants to merge 1 commit into
rust-lang:mainfrom
josetorrs:add-proc-macr-attribute-documentation
Open

Add proc_macro attribute documentation#158962
josetorrs wants to merge 1 commit into
rust-lang:mainfrom
josetorrs:add-proc-macr-attribute-documentation

Conversation

@josetorrs

@josetorrs josetorrs commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

part of #157604

r? @GuillaumeGomez

cc: @fmease

(I wasn't sure who to exactly tag. I see several PR's switch between you two)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 8, 2026
@rust-log-analyzer

This comment has been minimized.

@fmease fmease changed the title Add proc_macr attribute documentation Add proc_macro attribute documentation Jul 8, 2026
@rust-log-analyzer

This comment has been minimized.

Comment thread library/core/src/attribute_docs.rs Outdated
/// the [`TokenStream`] that replaces the invocation:
///
/// ```rust, ignore (requires depending on the proc-macro crate)
/// extern crate proc_macro;

@GuillaumeGomez GuillaumeGomez Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// extern crate proc_macro;
/// # extern crate proc_macro;

View changes since the review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this in

@GuillaumeGomez GuillaumeGomez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the small nit, looks good to me.

View changes since this review

@rustbot

rustbot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@josetorrs josetorrs marked this pull request as ready for review July 9, 2026 20:56
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2026
@josetorrs josetorrs force-pushed the add-proc-macr-attribute-documentation branch 2 times, most recently from 3a7e475 to 1574cdf Compare July 10, 2026 08:19
@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

Co-authored-by: Guillaume Gomez <contact@guillaume-gomez.fr>
@josetorrs josetorrs force-pushed the add-proc-macr-attribute-documentation branch from 1574cdf to 421ffc1 Compare July 15, 2026 12:09
@rustbot

rustbot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 421ffc1 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants