Skip to content

cleanup: upstream dropped AMX-TF32#158910

Closed
krasimirgg wants to merge 1 commit into
rust-lang:mainfrom
krasimirgg:jul26-llvm-amx
Closed

cleanup: upstream dropped AMX-TF32#158910
krasimirgg wants to merge 1 commit into
rust-lang:mainfrom
krasimirgg:jul26-llvm-amx

Conversation

@krasimirgg

@krasimirgg krasimirgg commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

LLVM recently dropped x86 AMX-TF32 llvm/llvm-project#207673. This is a cleanup similar to #148338.

@rustbot label llvm-main
r? @durin42

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels Jul 7, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@krasimirgg
krasimirgg marked this pull request as ready for review July 7, 2026 14:32
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2026
@rustbot

rustbot commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

Some changes occurred in std_detect

cc @Amanieu, @folkertdev, @sayantn

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 7, 2026
@durin42 durin42 mentioned this pull request Jul 7, 2026
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee

workingjubilee commented Jul 7, 2026

Copy link
Copy Markdown
Member

Can you add a

//@ normalize-stderr:

line at the top of the relevant test which fixes up the "and XX more" from a number like 75 or whatever that constantly gets diffed into a normalized value? It should leave the rest of the test output unchanged, in particular it has to suggest the same features first.

@folkertdev

folkertdev commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Could you make the changes in library/stdarch/crates/core_arch/* as a separate PR over at rust-lang/stdarch? As written this PR will break stdarch CI. We'll sync changes back over to here once merged over there.

@durin42

durin42 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Can you add a

//@ normalize-stderr:

line at the top of the relevant test which fixes up the "and XX more" from a number like 75 or whatever that constantly gets diffed into a normalized value? It should leave the rest of the test output unchanged, in particular it has to suggest the same features first.

That's already mailed as #158922 - probably that will land faster than this.

@krasimirgg krasimirgg mentioned this pull request Jul 8, 2026
Merged
@krasimirgg

krasimirgg commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Could you make the changes in library/stdarch/crates/core_arch/* as a separate PR over at rust-lang/stdarch? As written this PR will break stdarch CI. We'll sync changes back over to here once merged over there.

Prepped rust-lang/stdarch#2184.

@rustbot

rustbot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2026
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jul 9, 2026
@folkertdev

folkertdev commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This is blocked on the sync actually being merged #158968

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nikic

nikic commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 20a9498 has been approved by nikic

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158910 - krasimirgg:jul26-llvm-amx, r=nikic
d9b55bd 
cleanup: upstream dropped AMX-TF32

LLVM recently dropped x86 AMX-TF32 llvm/llvm-project#207673. This is a cleanup similar to rust-lang#148338.

@rustbot label llvm-main
r? @durin42
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 9, 2026
Closed
@JonathanBrouwer

JonathanBrouwer commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #159020 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 9, 2026
@rust-bors

rust-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#159020), which was unapproved.

View changes since this unapproval

@sayantn sayantn mentioned this pull request Jul 10, 2026
Open
3 tasks
@nikic

nikic commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@krasimirgg Looks like this is missing an update to library/std_detect/tests/x86-specific.rs.

nikic
nikic reviewed Jul 13, 2026
View reviewed changes
Comment thread library/std_detect/src/detect/arch/x86.rs

@nikic nikic Jul 13, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a leftover mention in a comment in this file.

View changes since the review

@folkertdev folkertdev mentioned this pull request Jul 14, 2026
Closed
@gmittert gmittert mentioned this pull request Jul 14, 2026
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 15, 2026
@jhpratt
Rollup merge of rust-lang#159310 - gmittert:RmAmxTf32, r=sayantn,work…
bd86099 
…ingjubilee

cleanup: upstream dropped AMX-TF32

LLVM recently dropped x86 AMX-TF32 llvm/llvm-project#207673. This is a re-upload of [rust-lang#158910](rust-lang#158910) as the author is out on vacation for this week.

I've also removed the leftover references to amx-tf32 that were missed in the original PR which caused it to fail the roll up.

r? @durin42
rust-timer added a commit that referenced this pull request Jul 15, 2026
@rust-timer
Unrolled build for #159310
5755493 
Rollup merge of #159310 - gmittert:RmAmxTf32, r=sayantn,workingjubilee

cleanup: upstream dropped AMX-TF32

LLVM recently dropped x86 AMX-TF32 llvm/llvm-project#207673. This is a re-upload of [#158910](#158910) as the author is out on vacation for this week.

I've also removed the leftover references to amx-tf32 that were missed in the original PR which caused it to fail the roll up.

r? @durin42
pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Jul 16, 2026
@jhpratt
Rollup merge of #159310 - gmittert:RmAmxTf32, r=sayantn,workingjubilee
62e6cd6 
cleanup: upstream dropped AMX-TF32

LLVM recently dropped x86 AMX-TF32 llvm/llvm-project#207673. This is a re-upload of [#158910](rust-lang/rust#158910) as the author is out on vacation for this week.

I've also removed the leftover references to amx-tf32 that were missed in the original PR which caused it to fail the roll up.

r? @durin42
@nikic

nikic commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Closing this in favor of the merged #159310.

@nikic nikic closed this Jul 16, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikic nikic nikic left review comments

Assignees

@durin42 durin42

Labels

llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@krasimirgg @rust-log-analyzer @rustbot @workingjubilee @folkertdev @durin42 @nikic @JonathanBrouwer