Skip to content

Closures inherit #[optimize] from the enclosing function by default.#158901

Open
veluca93 wants to merge 1 commit into
rust-lang:mainfrom
veluca93:optimize-attr-closure-inherit
Open

Closures inherit #[optimize] from the enclosing function by default.#158901
veluca93 wants to merge 1 commit into
rust-lang:mainfrom
veluca93:optimize-attr-closure-inherit

Conversation

@veluca93

@veluca93 veluca93 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Tracking issue: #54882
Stabilization PR: #157273

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 7, 2026
@rustbot

rustbot commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

@fee1-dead fee1-dead added S-waiting-on-t-lang Status: Awaiting decision from T-lang and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2026
@fee1-dead

Copy link
Copy Markdown
Member

Waiting on t-lang per #157273 (comment)

@fee1-dead fee1-dead added I-lang-nominated Nominated for discussion during a lang team meeting. and removed I-lang-nominated Nominated for discussion during a lang team meeting. labels Jul 9, 2026
@tmandry

tmandry commented Jul 16, 2026

Copy link
Copy Markdown
Member

The lang team discussed this change today and was in favor: #157562 (comment)

@veluca93

Copy link
Copy Markdown
Contributor Author

I don't believe this is blocked on lang anymore, but I don't think I can remove the tag myself.

@mejrs mejrs added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-t-lang Status: Awaiting decision from T-lang labels Jul 21, 2026

@fee1-dead fee1-dead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? scottmcm
could you check if the codegen-llvm CHECK annotations here are idiomatic or is there a better way?

View changes since this review

Comment thread tests/codegen-llvm/optimize-closures-inheritance.rs
@rustbot rustbot assigned scottmcm and unassigned fee1-dead Jul 22, 2026
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2026
@rustbot

rustbot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@veluca93
veluca93 force-pushed the optimize-attr-closure-inherit branch from 3c5ebd5 to f24fa6f Compare July 22, 2026 05:49
@veluca93

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants