Skip to content

remove UnevaluatedConstKind::def_id#157374

Open
khyperia wants to merge 1 commit into
rust-lang:mainfrom
khyperia:remove-UnevaluatedConstKind-def_id
Open

remove UnevaluatedConstKind::def_id#157374
khyperia wants to merge 1 commit into
rust-lang:mainfrom
khyperia:remove-UnevaluatedConstKind-def_id

Conversation

@khyperia
Copy link
Copy Markdown
Contributor

@khyperia khyperia commented Jun 3, 2026

this is some of the const side of #152245

not quite a full removal, there's still some spicy things such as UnevaluatedConstKind::def_span remaining that won't quite work for new non-DefID UnevaluatedConstKind cases, but IMO this is the bulk of the work, and feature-specific things can deal with their quirks in their own PRs when they know their own use cases.

r? @BoxyUwU

self-reminder: file an issue on what to do about rustc_public's handling of the raw DefIds in rustc_public AliasTy/AliasConst

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 3, 2026

Some changes occurred in const_evaluatable.rs

cc @BoxyUwU

changes to the core type system

cc @lcnr

Some changes occurred in abstract_const.rs

cc @BoxyUwU

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2026
@rustbot rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 3, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 3, 2026

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@rust-bors

This comment has been minimized.

@khyperia khyperia force-pushed the remove-UnevaluatedConstKind-def_id branch from 10e75d3 to 5070cba Compare June 4, 2026 04:36
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 4, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants