Add more tests for the optimize attribute#157297
Open
veluca93 wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
jieyouxu
reviewed
Jun 2, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
jieyouxu
reviewed
Jun 2, 2026
This comment has been minimized.
This comment has been minimized.
veluca93
force-pushed
the
more-optimize-tests
branch
from
534f1da to
14b4baf
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
veluca93
force-pushed
the
more-optimize-tests
branch
from
14b4baf to
1333de7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jieyouxu
approved these changes
Jun 3, 2026
veluca93
force-pushed
the
more-optimize-tests
branch
from
1333de7 to
fba4788
Compare
This comment has been minimized.
This comment has been minimized.
jieyouxu
approved these changes
Jun 3, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 3, 2026
…eyouxu Add more tests for the `optimize` attribute Tracking issue: rust-lang#54882 Stabilization PR: rust-lang#157273
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 3, 2026
…eyouxu Add more tests for the `optimize` attribute Tracking issue: rust-lang#54882 Stabilization PR: rust-lang#157273
Contributor
|
💔 I suspect this PR failed tests as part of a rollup Link to failure: #157375 (comment) Caused by a soft conflict with #157332, please rebase and reapprove after that merges |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#157375), which was unapproved. |
Member
|
I'll give this a slight p and don't rollup since this change seems conflict prone, and has now bounced twice. |
This comment has been minimized.
This comment has been minimized.
veluca93
force-pushed
the
more-optimize-tests
branch
from
fba4788 to
e63c09f
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Contributor
|
Note that #157332 hasn't merged yet, so we need to wait with approving this still. That pr conflicted with yet another pr and had to wait a rollup 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
Tracking issue: #54882
Stabilization PR: #157273