Rollup of 2 pull requests by matthiaskrgr · Pull Request #157177 · rust-lang/rust

matthiaskrgr · 2026-05-31T03:01:50Z

Successful merges:

Async return ty #157165 (Async return ty)
Reorganize tests/ui/issues [2/N] #157176 (Reorganize tests/ui/issues [2/N])

@estebank

…tebank Async return ty r? @estebank Found this weird suggestion while doing something else. The fix isn't super involved, but it may save someone. Note the change between the stderr file in the first and second commit!

@Teapot4195

…t4195 Reorganize `tests/ui/issues` [2/N] Part of [GSoC'26 project](https://rust-lang.zulipchat.com/#narrow/channel/421156-gsoc/topic/Project.3A.20Reorganizing.20tests.2Fui.2Fissues) r? Kivooeo @Teapot4195

matthiaskrgr · 2026-05-31T03:02:08Z

@bors r+ rollup=never p=5

rust-bors · 2026-05-31T03:02:10Z

📌 Commit d41954e has been approved by matthiaskrgr

It is now in the queue for this repository.

rust-bors · 2026-05-31T06:42:02Z

☀️ Test successful - CI
Approved by: matthiaskrgr
Duration: 3h 10m 57s
Pushing f375177 to main...

rust-timer · 2026-05-31T06:42:38Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#157165	Async return ty	`640a1481a1a31380d615fefbc5195bdec95d94d7` (link)
#157176	Reorganize `tests/ui/issues` [2/N]	`89f59eefd51e8b0e683b57a132b8c99832a81831` (link)

previous master: e7a21fa256

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-05-31T06:44:47Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e7a21fa (parent) -> f375177 (this PR)

Test differences

Show 44 test diffs

Stage 1

[ui] tests/ui/async-await/async-closures/wrong-suggestion-result.rs: [missing] -> pass (J1)
[ui] tests/ui/autoref-autoderef/reborrow-mut-self-to-ref-self-method.rs: [missing] -> pass (J1)
[ui] tests/ui/coercion/box-dyn-to-ref-dyn.rs: [missing] -> pass (J1)
[ui] tests/ui/cross-crate/for-loop-in-match-on-self.rs: [missing] -> pass (J1)
[ui] tests/ui/derives/derive-hash-on-unit-struct.rs: [missing] -> pass (J1)
[ui] tests/ui/dst/reborrow-mut-dyn-trait-field.rs: [missing] -> pass (J1)
[ui] tests/ui/issues/issue-16278.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-16530.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-16562.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-16596.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-16643.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-16739.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-17033.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-17322.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-17746.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-17771.rs: pass -> [missing] (J1)
[ui] tests/ui/lexer/crlf-in-byte-string-literal.rs: [missing] -> pass (J1)
[ui] tests/ui/mismatched_types/deref-fn-ptr-arg-type-mismatch.rs: [missing] -> pass (J1)
[ui] tests/ui/regions/relate-bound-region-ref-type-param.rs: [missing] -> pass (J1)
[ui] tests/ui/typeck/unconstrained-impl-extra-parameter.rs: [missing] -> pass (J1)
[ui] tests/ui/unboxed-closures/rust-call-shim-through-trait-box.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/async-await/async-closures/wrong-suggestion-result.rs: [missing] -> pass (J0)
[ui] tests/ui/autoref-autoderef/reborrow-mut-self-to-ref-self-method.rs: [missing] -> pass (J0)
[ui] tests/ui/coercion/box-dyn-to-ref-dyn.rs: [missing] -> pass (J0)
[ui] tests/ui/cross-crate/for-loop-in-match-on-self.rs: [missing] -> pass (J0)
[ui] tests/ui/derives/derive-hash-on-unit-struct.rs: [missing] -> pass (J0)
[ui] tests/ui/dst/reborrow-mut-dyn-trait-field.rs: [missing] -> pass (J0)
[ui] tests/ui/issues/issue-16278.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-16530.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-16562.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-16596.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-16643.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-16739.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-17033.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-17322.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-17746.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-17771.rs: pass -> [missing] (J0)
[ui] tests/ui/lexer/crlf-in-byte-string-literal.rs: [missing] -> pass (J0)
[ui] tests/ui/mismatched_types/deref-fn-ptr-arg-type-mismatch.rs: [missing] -> pass (J0)
[ui] tests/ui/regions/relate-bound-region-ref-type-param.rs: [missing] -> pass (J0)
[ui] tests/ui/typeck/unconstrained-impl-extra-parameter.rs: [missing] -> pass (J0)
[ui] tests/ui/unboxed-closures/rust-call-shim-through-trait-box.rs: [missing] -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f375177a48bcab5e27d800b464fa25363c0198f1 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

optional-x86_64-gnu-parallel-frontend: 1h 47m -> 2h 29m (+39.0%)
dist-x86_64-solaris: 1h 14m -> 1h 38m (+32.9%)
x86_64-msvc-ext3: 1h 24m -> 1h 47m (+28.1%)
x86_64-gnu-stable: 2h 30m -> 1h 50m (-26.6%)
x86_64-gnu-gcc: 55m 52s -> 1h 9m (+23.9%)
dist-loongarch64-linux: 1h 30m -> 1h 50m (+22.9%)
x86_64-gnu: 2h 19m -> 1h 49m (-21.3%)
i686-msvc-1: 2h 53m -> 2h 17m (-21.1%)
dist-x86_64-apple: 2h 8m -> 1h 47m (-16.1%)
x86_64-msvc-2: 2h 20m -> 2h 37m (+12.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-05-31T07:37:22Z

Finished benchmarking commit (f375177): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	3

Max RSS (memory usage)

Results (primary -1.3%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.3%	[-1.3%, -1.3%]	1

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 513.315s -> 521.294s (1.55%)
Artifact size: 400.75 MiB -> 400.74 MiB (-0.00%)

zedddie and others added 6 commits May 29, 2026 00:06

move batch

4920200

wrong suggestion around asyncfn{mut,once,}

3bfbaa0

fix suggestion

1984d1f

bless batch

0635351

Rollup merge of rust-lang#157176 - zedddie:gsoc-batch-2-meow, r=Teapo…

d41954e

…t4195 Reorganize `tests/ui/issues` [2/N] Part of [GSoC'26 project](https://rust-lang.zulipchat.com/#narrow/channel/421156-gsoc/topic/Project.3A.20Reorganizing.20tests.2Fui.2Fissues) r? Kivooeo @Teapot4195

rust-bors Bot added the rollup A PR which is a rollup label May 31, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 31, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 31, 2026

rust-bors Bot merged commit f375177 into rust-lang:main May 31, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone May 31, 2026

rustbot added the perf-regression Performance regression. label May 31, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 2 pull requests#157177

Rollup of 2 pull requests#157177
rust-bors[bot] merged 6 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-ZLL6iEP

matthiaskrgr commented May 31, 2026

Uh oh!

matthiaskrgr commented May 31, 2026

Uh oh!

rust-bors Bot commented May 31, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 31, 2026

Uh oh!

Uh oh!

rust-timer commented May 31, 2026

Uh oh!

github-actions Bot commented May 31, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented May 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

matthiaskrgr commented May 31, 2026

Uh oh!

matthiaskrgr commented May 31, 2026

Uh oh!

rust-bors Bot commented May 31, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 31, 2026

Uh oh!

Uh oh!

rust-timer commented May 31, 2026

Uh oh!

github-actions Bot commented May 31, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented May 31, 2026

Overall result: ❌ regressions - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants