Don't suggest semicolon after if expression closing brace#157175
Open
Unique-Usman wants to merge 1 commit into
Open
Don't suggest semicolon after if expression closing brace#157175Unique-Usman wants to merge 1 commit into
Unique-Usman wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
r? @estebank |
JonathanBrouwer
requested changes
May 30, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
When a type mismatch occurs inside an if expression, the compiler incorrectly suggests adding a semicolon after the closing brace. This doesn't fix the error. The fix excludes all if expressions from the suggest_semicolon_at_end suggestion in coercion.rs. Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Kivooeo
reviewed
May 31, 2026
| | | ||
| = note: expected unit type `()` | ||
| found mutable reference `&mut V` | ||
| help: consider using a semicolon here |
Member
There was a problem hiding this comment.
(not related to this pr)
eh, what a wording of this help, why not something "at the end of the statement", i guess it should explain somehow why this requiers semicolon here
Kivooeo
approved these changes
May 31, 2026
Contributor
|
@bors r=JonathanBrouwer,Kivooeo rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a type mismatch occurs inside an if expression, the compiler incorrectly suggests adding a semicolon after the closing brace. This doesn't fix the error. The fix excludes all if expressions from the suggest_semicolon_at_end suggestion in coercion.rs.
Fix: #156621