Skip to content

Add regression test for issue #87290#157160

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
pbkx:issue-87290-closure-lifetime-test
May 31, 2026
Merged

Add regression test for issue #87290#157160
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
pbkx:issue-87290-closure-lifetime-test

Conversation

@pbkx
Copy link
Copy Markdown
Contributor

@pbkx pbkx commented May 30, 2026

Issue #87290 is labeled E-needs-test for explicit non-'static lifetimes in closure argument types.

This adds a check-pass UI test for explicit lifetimes in closure argument types.

Fixes #87290.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 30, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 30, 2026

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 16 candidates

Copy link
Copy Markdown
Member

@Kivooeo Kivooeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a PR! One small nit

View changes since this review

Comment thread tests/ui/closures/explicit-closure-lifetime-issue-87290.rs Outdated
Co-authored-by: Kivooeo <75776246+Kivooeo@users.noreply.github.com>
@Kivooeo Kivooeo assigned Kivooeo and unassigned JonathanBrouwer May 30, 2026
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented May 31, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 31, 2026

📌 Commit 5665d70 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 31, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 31, 2026

☀️ Test successful - CI
Approved by: Kivooeo
Duration: 3h 9m 14s
Pushing e7a21fa to main...

@rust-bors rust-bors Bot merged commit e7a21fa into rust-lang:main May 31, 2026
13 checks passed
@rustbot rustbot added this to the 1.98.0 milestone May 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e248841 (parent) -> e7a21fa (this PR)

Test differences

Show 4 test diffs

Stage 1

  • [ui] tests/ui/closures/explicit-closure-lifetime-issue-87290.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/closures/explicit-closure-lifetime-issue-87290.rs: [missing] -> pass (J1)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e7a21fa2562f67cf9cac407c29287a16862b4463 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-llvm-mingw: 1h 11m -> 1h 58m (+65.6%)
  2. optional-x86_64-gnu-parallel-frontend: 2h 43m -> 1h 47m (-34.0%)
  3. x86_64-msvc-ext1: 1h 42m -> 2h 12m (+29.1%)
  4. dist-loongarch64-musl: 1h 26m -> 1h 49m (+25.6%)
  5. pr-check-1: 27m 15s -> 33m 52s (+24.3%)
  6. dist-ohos-x86_64: 1h 2m -> 1h 17m (+23.4%)
  7. x86_64-gnu-gcc-core-tests: 14m 26s -> 11m 4s (-23.3%)
  8. dist-x86_64-solaris: 1h 37m -> 1h 14m (-23.3%)
  9. x86_64-gnu-gcc: 1h 11m -> 55m 52s (-22.1%)
  10. dist-aarch64-apple: 1h 38m -> 1h 59m (+21.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e7a21fa): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.1% [-0.1%, -0.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.1% [-0.1%, -0.1%] 1

Max RSS (memory usage)

Results (primary 1.4%, secondary 6.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)
6.9% [6.9%, 6.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.4% [1.4%, 1.4%] 1

Cycles

Results (primary 1.9%, secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.9% [1.9%, 1.9%] 1
Regressions ❌
(secondary)
3.4% [2.0%, 4.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.9% [1.9%, 1.9%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 511.377s -> 513.315s (0.38%)
Artifact size: 400.74 MiB -> 400.75 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicit non-'static lifetimes ignored in explicit closure argument types

5 participants