library: use strict provenance lints consistently by hanna-kruppe · Pull Request #156832 · rust-lang/rust

hanna-kruppe · 2026-05-22T13:39:00Z

The fuzzy_provenance_casts lint is enabled in most of the standard library, but its identical twin lossy_provenance_casts was not. As discussed in the tracking issue for those lints, there doesn't seem to be any good reason to enable one without the other. This PR applies this principle and as a result removes some unnecessary ptr->int as casts.

It's also preparation for merging the two lints, which removes the option of only enabling fuzzy_provenance_casts.

Tracking issue: #130351

rustbot · 2026-05-22T13:39:06Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 8 candidates

hanna-kruppe · 2026-05-23T14:01:46Z

The CI failure is due to a clippy lint using rustc_hir_typeck to test if an as cast would be possible, and rustc emitting the strict provenance lints during this check. I created rust-lang/rust-clippy#17063 for that, it's not solely a problem of the strict provenance lints. The specific expressions that trigger the bug in the CI job are these two pointer->int transmutes:

rust/library/core/src/array/drain.rs

Line 83 in 54333ff

let len = unsafe { transmute::<*mut T, usize>(self.end_or_len) };
rust/library/core/src/array/drain.rs

Line 114 in 54333ff

transmute::<*mut T, usize>(self.end_or_len)

The "invalid span" warnings seems to caused by a mix of that clippy issue (check_cast uses DUMMY_SPAN because diagnostics are not expected) and the span manipulation in the lints. I created #156850 for another issue with the span manipulation that I discovered while debugging, but I think that one's unrelated (I haven't been able to provoke an invalid span without the clippy issue in the mix).

I didn't find an easy workaround for the clippy bug that I'd be comfortable including in this PR. So I'll try moving the strict provenance lints out of the HIR typechecking path and convert them to normal late lints (edit: opened #156862 for this). So this PR should be ready for review in theory, but can't pass CI until I've either done that or someone finds another fix for rust-lang/rust-clippy#17063

@rustbot blocked

rustbot · 2026-05-25T17:28:22Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

The `fuzzy_provenance_casts` lint is enabled in most of the standard library, but its identical twin `lossy_provenance_casts` was not. As discussed in the tracking issue for those lints, there doesn't seem to be any good reason to enable one without the other. This PR applies this principle and as a result removes some unnecessary ptr->int `as` casts. It's also preparation for merging the two lints, which removes the option of only enabling `fuzzy_provenance_casts`.

hanna-kruppe · 2026-05-25T18:47:12Z

#156862 was merged and fixed the previous CI failure as expected. Another job failed after rebase but that was spurious (actions runner died midway), so: @rustbot ready

jhpratt · 2026-05-30T17:36:10Z

r? jhpratt

@bors r+

rust-bors · 2026-05-30T17:36:12Z

📌 Commit fed6279 has been approved by jhpratt

It is now in the queue for this repository.

rust-bors · 2026-05-30T20:54:24Z

⌛ Testing commit fed6279 with merge 6402f0d...

Workflow: https://github.com/rust-lang/rust/actions/runs/26694683369

…ts, r=jhpratt library: use strict provenance lints consistently The `fuzzy_provenance_casts` lint is enabled in most of the standard library, but its identical twin `lossy_provenance_casts` was not. As discussed in the tracking issue for those lints, there doesn't seem to be any good reason to enable one without the other. This PR applies this principle and as a result removes some unnecessary ptr->int `as` casts. It's also preparation for merging the two lints, which removes the option of only enabling `fuzzy_provenance_casts`. Tracking issue: #130351

JonathanBrouwer · 2026-05-30T21:05:13Z

💔 This PR failed tests as part of a rollup
After fixing the problem, consider running a try job for the failed job before re-approving
@bors r-

Link to failure:
#157167 (comment)

rust-bors · 2026-05-30T21:05:19Z

This pull request was unapproved.

This PR was contained in a rollup (#157167), which was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/26694683369

View changes since this unapproval

hanna-kruppe · 2026-05-31T08:32:24Z

Added a commit that should fix that failure. @bors ready

rust-bors · 2026-05-31T08:32:27Z

Unknown command "ready". Run @bors help to see available commands.

hanna-kruppe · 2026-05-31T08:36:10Z

@rustbot ready

jhpratt · 2026-05-31T21:24:11Z

@bors try jobs=dist-ohos-armv7

…ts, r=<try> library: use strict provenance lints consistently try-job: dist-ohos-armv7

rust-bors · 2026-05-31T22:53:36Z

☀️ Try build successful (CI)
Build commit: 78b1000 (78b1000f14a801be0154240cbc0c38aec312923c, parent: 39e7b2ae75639d6014b159b1cea48781d35ad3e7)

jhpratt · 2026-05-31T22:55:32Z

@bors r+

rust-bors · 2026-05-31T22:55:35Z

📌 Commit 732998a has been approved by jhpratt

It is now in the queue for this repository.

…venance-lints, r=jhpratt library: use strict provenance lints consistently The `fuzzy_provenance_casts` lint is enabled in most of the standard library, but its identical twin `lossy_provenance_casts` was not. As discussed in the tracking issue for those lints, there doesn't seem to be any good reason to enable one without the other. This PR applies this principle and as a result removes some unnecessary ptr->int `as` casts. It's also preparation for merging the two lints, which removes the option of only enabling `fuzzy_provenance_casts`. Tracking issue: rust-lang#130351

Rollup of 6 pull requests Successful merges: - #156832 (library: use strict provenance lints consistently) - #157223 (rustdoc: Fix ICE on delegated async functions) - #156528 (Explicitly request copying `rustc-dev` artifacts for rustfmt/clippy and add rustc libs path for rustc-private tools under `download-rustc`) - #157059 (update TargetFeature::Forbidden docs) - #157159 (Fix CI free-disk-space-linux script) - #157221 (Help people looking for random bytes find `DefaultRandomSource.fill_bytes`)

Rollup merge of #156832 - hanna-kruppe:consistent-strict-provenance-lints, r=jhpratt library: use strict provenance lints consistently The `fuzzy_provenance_casts` lint is enabled in most of the standard library, but its identical twin `lossy_provenance_casts` was not. As discussed in the tracking issue for those lints, there doesn't seem to be any good reason to enable one without the other. This PR applies this principle and as a result removes some unnecessary ptr->int `as` casts. It's also preparation for merging the two lints, which removes the option of only enabling `fuzzy_provenance_casts`. Tracking issue: #130351

rustbot assigned Mark-Simulacrum May 22, 2026

rustbot added O-SGX Target: SGX S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 22, 2026

This comment has been minimized.

Sign in to view

hanna-kruppe force-pushed the consistent-strict-provenance-lints branch from 49b7330 to ce7d549 Compare May 22, 2026 13:40

This comment has been minimized.

Sign in to view

hanna-kruppe marked this pull request as draft May 22, 2026 14:45

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2026

This comment has been minimized.

Sign in to view

hanna-kruppe force-pushed the consistent-strict-provenance-lints branch from ba63f5d to 2509ca0 Compare May 23, 2026 14:00

hanna-kruppe marked this pull request as ready for review May 23, 2026 14:00

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 23, 2026

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2026

This comment has been minimized.

Sign in to view

hanna-kruppe force-pushed the consistent-strict-provenance-lints branch from 2509ca0 to 02378db Compare May 25, 2026 17:28

hanna-kruppe force-pushed the consistent-strict-provenance-lints branch from 02378db to fed6279 Compare May 25, 2026 18:45

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels May 25, 2026

rustbot assigned jhpratt May 30, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 30, 2026

allow target-dependent int2ptr cast for pthread_t

732998a

rustbot added the O-unix Operating system: Unix-like label May 31, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 31, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 31, 2026

Auto merge of #156832 - hanna-kruppe:consistent-strict-provenance-lin…

78b1000

…ts, r=<try> library: use strict provenance lints consistently try-job: dist-ohos-armv7

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2026

jhpratt mentioned this pull request Jun 1, 2026

Rollup of 6 pull requests #157225

Closed

This was referenced Jun 1, 2026

Rollup of 7 pull requests #157227

Closed

Rollup of 6 pull requests #157228

Merged

rust-bors Bot merged commit 5d3c4fb into rust-lang:main Jun 1, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 1, 2026

Uh oh!

Conversation

hanna-kruppe commented May 22, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

hanna-kruppe commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rustbot commented May 25, 2026

Uh oh!

hanna-kruppe commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented May 30, 2026

Uh oh!

rust-bors Bot commented May 30, 2026

Uh oh!

rust-bors Bot commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented May 30, 2026

Uh oh!

hanna-kruppe commented May 31, 2026

Uh oh!

rust-bors Bot commented May 31, 2026

Uh oh!

hanna-kruppe commented May 31, 2026

Uh oh!

jhpratt commented May 31, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 31, 2026

Uh oh!

jhpratt commented May 31, 2026

Uh oh!

rust-bors Bot commented May 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hanna-kruppe commented May 22, 2026 •

edited by rustbot

Loading

hanna-kruppe commented May 23, 2026 •

edited

Loading

hanna-kruppe commented May 25, 2026 •

edited

Loading

rust-bors Bot commented May 30, 2026 •

edited

Loading

JonathanBrouwer commented May 30, 2026 •

edited

Loading