Skip to content

rustdoc: fix ICE when delegating functions with impl Trait as argument type#156498

Open
cijiugechu wants to merge 1 commit into
rust-lang:mainfrom
cijiugechu:fn_delegation-rustdoc
Open

rustdoc: fix ICE when delegating functions with impl Trait as argument type#156498
cijiugechu wants to merge 1 commit into
rust-lang:mainfrom
cijiugechu:fn_delegation-rustdoc

Conversation

@cijiugechu
Copy link
Copy Markdown
Member

@cijiugechu cijiugechu commented May 12, 2026

HIR signatures for delegation items contain InferDelegation placeholders, clean the inherited fn_sig signature instead.

Closes #155728

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels May 12, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 12, 2026

r? @lolbinarycat

rustbot has assigned @lolbinarycat.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustdoc
  • rustdoc expanded to 9 candidates
  • Random selection from GuillaumeGomez, camelid, fmease, lolbinarycat, notriddle

@cijiugechu cijiugechu added the F-fn_delegation `#![feature(fn_delegation)]` label May 12, 2026
Comment thread src/librustdoc/clean/simplify.rs
@lolbinarycat lolbinarycat changed the title rustdoc: fix delegated impl signatures rustdoc: fix ICE when delegating functions with impl Trait as argument type May 12, 2026
Comment thread tests/rustdoc-html/fn-delegation-impl-trait.rs
Comment thread tests/rustdoc-html/fn-delegation-impl-trait.rs Outdated
Comment thread tests/rustdoc-html/fn-delegation-impl-trait.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2026
@cijiugechu cijiugechu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 14, 2026
@lolbinarycat
Copy link
Copy Markdown
Contributor

Looks good! If you could also squash your commits that would be great!

@cijiugechu cijiugechu force-pushed the fn_delegation-rustdoc branch from d9493f2 to 04da15e Compare May 17, 2026 03:50
@cijiugechu
Copy link
Copy Markdown
Member Author

Looks good! If you could also squash your commits that would be great!

Done, thanks!

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jun 1, 2026

☔ The latest upstream changes (presumably #157228) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-fn_delegation `#![feature(fn_delegation)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: rustdoc: assertion failed: cx.impl_trait_bounds.is_empty()

3 participants