Open
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Collaborator
|
|
Bryntet
force-pushed
the
remove-pointee-parser
branch
from
236ded1 to
2598b50
Compare
Collaborator
|
Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
JonathanBrouwer
approved these changes
Apr 14, 2026
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 14, 2026
…onathanBrouwer remove PointeeParser this parser does nothing currently, as the current scope of `rustc_attr_parsing` only includes builtin attributes, and not derive macros it isn't defined in `compiler/rustc_feature/src/builtin_attrs.rs` all the actual parsing for `#[pointee]` is actually handled in `compiler/rustc_builtin_macros/src/deriving/coerce_pointee.rs` r? @JonathanBrouwer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this parser does nothing currently, as the current scope of
rustc_attr_parsingonly includes builtin attributes, and not derive macrosit isn't defined in
compiler/rustc_feature/src/builtin_attrs.rsall the actual parsing for
#[pointee]is actually handled incompiler/rustc_builtin_macros/src/deriving/coerce_pointee.rsr? @JonathanBrouwer