remove ibraheemdev from review rotation#155303
Open
WaffleLapkin wants to merge 1 commit intorust-lang:mainfrom
Open
remove ibraheemdev from review rotation#155303WaffleLapkin wants to merge 1 commit intorust-lang:mainfrom
WaffleLapkin wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
|
rustbot
added
A-meta
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
fmease
reviewed
Apr 14, 2026
Comment on lines
1476
to
1483
| libs = [ | ||
| "@Mark-Simulacrum", | ||
| "@workingjubilee", | ||
| "@jhpratt", | ||
| "@tgross35", | ||
| "@thomcc", | ||
| "@ibraheemdev", | ||
| "@joboet", | ||
| ] |
Member
There was a problem hiding this comment.
I'm surprised to see that T-libs doesn't use triagebot's review queue tracking. If they did, it would be as simple as PM'ing triagebot as ibraheemdev work set-team-rotation-mode libs off.
Contributor
There was a problem hiding this comment.
Doesn't this work as an override for what's in the file? I feel like I have used it in the past.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ibraheemdev haven't reviewed any r-l/r PRs since October last year and has a backlog of 8 PRs at the moment of writing this.
@ibraheemdev thank you for the reviews that you have done in the past! feel free to re-add yourself once you have time for this again :)