Skip to content

fix arch names in cfg pretty printer#155293

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
usamoi:rustdoc-loongarch
Apr 15, 2026
Merged

fix arch names in cfg pretty printer#155293
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
usamoi:rustdoc-loongarch

Conversation

@usamoi
Copy link
Copy Markdown
Contributor

@usamoi usamoi commented Apr 14, 2026

It's introduced in #154328.

@rustbot label +beta-nominated

(it affects the documentation of core::arch::loongarch32 and core::arch::loongarch64)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 14, 2026

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustdoc
  • rustdoc expanded to 9 candidates
  • Random selection from GuillaumeGomez, fmease, lolbinarycat, notriddle

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 14, 2026

Error: Parsing relabel command in comment failed: ...'-nominated' | error: a label delta at >| ' (it affec'...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@GuillaumeGomez
Copy link
Copy Markdown
Member

Thanks! r=me once CI pass.

@bors delegate+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 14, 2026

✌️ @usamoi, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, then please make that change and post @bors r=GuillaumeGomez.

@usamoi usamoi force-pushed the rustdoc-loongarch branch from 3a281b0 to a0002d0 Compare April 14, 2026 15:22
@usamoi
Copy link
Copy Markdown
Contributor Author

usamoi commented Apr 14, 2026

I just noticed that "AMD GPU" was also misspelled as "AMG GPU".

@usamoi usamoi force-pushed the rustdoc-loongarch branch from a0002d0 to b9ba18f Compare April 14, 2026 15:24
@usamoi usamoi changed the title fix loongarch names in cfg pretty printer fix arch names in cfg pretty printer Apr 14, 2026
@GuillaumeGomez
Copy link
Copy Markdown
Member

Then go for it. :)

@usamoi usamoi force-pushed the rustdoc-loongarch branch from b9ba18f to 05081b9 Compare April 14, 2026 15:39
@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Apr 14, 2026
@usamoi
Copy link
Copy Markdown
Contributor Author

usamoi commented Apr 14, 2026

@bors r=GuillaumeGomez

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 14, 2026

📌 Commit 05081b9 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2026
@fmease
Copy link
Copy Markdown
Member

fmease commented Apr 14, 2026

Beta backport accepted as per #t-rustdoc > beta-nominated: #155293 @ 💬.
@rustbot label beta-accepted

Note

A backport PR will be authored by the release team at the end of the current development cycle.
Backport labels are hereinafter handled by them.

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 14, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 14, 2026
…umeGomez

fix arch names in cfg pretty printer

It's introduced in rust-lang#154328.

@rustbot label +beta-nominated

(it affects the documentation of [`core::arch::loongarch32`](https://doc.rust-lang.org/beta/core/arch/loongarch32/index.html) and [`core::arch::loongarch64`](https://doc.rust-lang.org/beta/core/arch/loongarch64/index.html))
rust-bors bot pushed a commit that referenced this pull request Apr 14, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #153536 (Add `const_param_ty_unchecked` gate)
 - #153815 (Fix ICE when Self is used in enum discriminant of a generic enum)
 - #154882 (Gate tuple const params behind `min_adt_const_params` feature)
 - #155293 (fix arch names in cfg pretty printer)
 - #154765 (Clarify ascii whitespace exclusion of vertical tab in the doc)
 - #155172 (Some small nits for supertrait_item_shadowing, and additional testing)
 - #155279 (Test/lexer unicode pattern white space)
 - #155280 (Tests for precise-capture through RPIT and TAIT)
 - #155304 (remove PointeeParser)
rust-bors bot pushed a commit that referenced this pull request Apr 15, 2026
Rollup of 13 pull requests

Successful merges:

 - #154882 (Gate tuple const params behind `min_adt_const_params` feature)
 - #155259 (explicit-tail-calls: disable two tests on LoongArch)
 - #155293 (fix arch names in cfg pretty printer)
 - #155314 (`BorrowedBuf`: Update outdated safety comments in `set_init` users.)
 - #153469 (docs: clarify path search behavior in std::process::Command::new)
 - #154765 (Clarify ascii whitespace exclusion of vertical tab in the doc)
 - #155172 (Some small nits for supertrait_item_shadowing, and additional testing)
 - #155279 (Test/lexer unicode pattern white space)
 - #155280 (Tests for precise-capture through RPIT and TAIT)
 - #155301 (Delete unused `rustc_trait_selection` errors.)
 - #155303 (remove ibraheemdev from review rotation)
 - #155304 (remove PointeeParser)
 - #155319 (Remove dead diagnostic structs.)
@rust-bors rust-bors bot merged commit 4886550 into rust-lang:main Apr 15, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 15, 2026
rust-timer added a commit that referenced this pull request Apr 15, 2026
Rollup merge of #155293 - usamoi:rustdoc-loongarch, r=GuillaumeGomez

fix arch names in cfg pretty printer

It's introduced in #154328.

@rustbot label +beta-nominated

(it affects the documentation of [`core::arch::loongarch32`](https://doc.rust-lang.org/beta/core/arch/loongarch32/index.html) and [`core::arch::loongarch64`](https://doc.rust-lang.org/beta/core/arch/loongarch64/index.html))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants