Skip to content

attribute cleanup: rustc_confusables#155286

Open
mejrs wants to merge 1 commit intorust-lang:mainfrom
mejrs:confusables
Open

attribute cleanup: rustc_confusables#155286
mejrs wants to merge 1 commit intorust-lang:mainfrom
mejrs:confusables

Conversation

@mejrs
Copy link
Copy Markdown
Contributor

@mejrs mejrs commented Apr 14, 2026

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 14, 2026

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 14, 2026
mejrs
mejrs commented Apr 14, 2026
View reviewed changes
Bryntet
Bryntet reviewed Apr 14, 2026
View reviewed changes
JonathanBrouwer
JonathanBrouwer reviewed Apr 14, 2026
View reviewed changes
compiler/rustc_hir_typeck/src/method/probe.rs
return false;
};
let hir_id = self.fcx.tcx.local_def_id_to_hir_id(local_def_id);
let attrs = self.fcx.tcx.hir_attrs(hir_id);
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer Apr 14, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code ran this query only one time, the new code runs it multiple times, lets see if that matters

View changes since the review

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Apr 14, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Apr 14, 2026
@bors
Auto merge of #155286 - mejrs:confusables, r=<try>
66dc2b0 
attribute cleanup: rustc_confusables
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 14, 2026
JonathanBrouwer
JonathanBrouwer approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if perf does not regress

View changes since this review

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Apr 14, 2026

@bors delegate

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 14, 2026

✌️ @mejrs, you can now approve this pull request!

If @JonathanBrouwer told you to "r=me" after making some further change, then please make that change and post @bors r=JonathanBrouwer.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 14, 2026

☀️ Try build successful (CI)
Build commit: 66dc2b0 (66dc2b0a0b032e0a19ddf7ad6bc699bbfb3fa63c, parent: 12f35ad39ed3e39df4d953c46d4f6cc6c82adc96)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 14, 2026

Finished benchmarking commit (66dc2b0): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary 9.6%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 11.4% [2.5%, 19.8%] 7
Regressions ❌
(secondary)		 4.2% [2.7%, 7.0%] 3
Improvements ✅
(primary)		 -2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)		 -3.4% [-4.4%, -2.3%] 2
All ❌✅ (primary) 9.6% [-2.9%, 19.8%] 8

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.936s -> 490.673s (0.15%)
Artifact size: 394.18 MiB -> 394.15 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 14, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Apr 15, 2026

@bors r+ rollup
Perf is noise

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 15, 2026

📌 Commit f17ca97 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 15, 2026
@JonathanBrouwer
Rollup merge of rust-lang#155286 - mejrs:confusables, r=JonathanBrouwer
1de718c 
attribute cleanup: rustc_confusables

r? @jdonszelmann
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 15, 2026
Open
rust-bors bot pushed a commit that referenced this pull request Apr 15, 2026
@bors
Auto merge of #155339 - JonathanBrouwer:rollup-2nyGW0a, r=JonathanBro…
71f4f54 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #155331 (Reformat `top_level_options!` and `options!` macro declarations)
 - #155332 (bump std libc to `0.2.185`)
 - #155286 (attribute cleanup: rustc_confusables)
 - #155306 (`CValue::zst()` - add missing "ZST" in docs)
 - #155311 (various small `rustc_expand` cleanups)
rust-bors bot pushed a commit that referenced this pull request Apr 15, 2026
@bors
Auto merge of #155339 - JonathanBrouwer:rollup-2nyGW0a, r=JonathanBro…
9620eae 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #155331 (Reformat `top_level_options!` and `options!` macro declarations)
 - #155332 (bump std libc to `0.2.185`)
 - #155286 (attribute cleanup: rustc_confusables)
 - #155306 (`CValue::zst()` - add missing "ZST" in docs)
 - #155311 (various small `rustc_expand` cleanups)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

+1 more reviewer

@Bryntet Bryntet Bryntet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mejrs @rustbot @JonathanBrouwer @rust-timer @Bryntet @jdonszelmann